Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct linting issue in rules #2055

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

stephanmiehe
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it: Fixes a linting issue in the rules yaml

Which issue(s) this PR fixes: None

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: No

NONE

Signed-off-by: Stephan Miehe <[email protected]>
@stephanmiehe
Copy link
Contributor Author

/milestone 0.33.0

@poiana
Copy link
Contributor

poiana commented Jun 9, 2022

@stephanmiehe: You must be a member of the falcosecurity/maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Falco maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 0.33.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/ok-to-test

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Jun 9, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

LGTM label has been added.

Git tree hash: 337627679f2406468c0ee75031cddb308e699e99

@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, stephanmiehe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasondellaluce
Copy link
Contributor

Closing and re-opening to trigger the CI.

/close

@poiana poiana closed this Jun 10, 2022
@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

@jasondellaluce: Closed this PR.

In response to this:

Closing and re-opening to trigger the CI.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/reopen

@poiana poiana reopened this Jun 10, 2022
@poiana
Copy link
Contributor

poiana commented Jun 10, 2022

@jasondellaluce: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@poiana poiana merged commit c782655 into falcosecurity:master Jun 10, 2022
@stephanmiehe stephanmiehe deleted the lint-rules branch June 10, 2022 14:14
@jasondellaluce jasondellaluce removed this from the 0.33.0 milestone Jun 17, 2022
@jasondellaluce jasondellaluce added this to the 0.32.1 milestone Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants