build: upgrade deps and cmakefiles improvements #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
gnosek
reviewed
Apr 14, 2021
1 task
leogr
force-pushed
the
build/upgrade-deps
branch
from
278e3fe to
24e5613
Compare
|
Update: I'm re-working this PR again |
leogr
force-pushed
the
build/upgrade-deps
branch
7 times, most recently
from
ce60c9a to
86a473a
Compare
6 tasks
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
This commit also introduces other relevant changes: - now using gRPC cmakefiles (that requires a workaround, see the comment) - added support for gpr lib (likely needed by dependant, for example Falco) - switched from `_unsecure` grpc libs to default ones Signed-off-by: Leonardo Grasso <[email protected]>
… small improvements Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
The deprecation annotation produced warnings when building. Since the warning is not really relevant to libs code and might be problematic for dependant projects (especially when a project uses warnings as errors, like Falco), we are just suppressing it by removing the annotation. Co-authored-by: Grzegorz Nosek <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
leodido
approved these changes
May 11, 2021
|
LGTM label has been added. Git tree hash: 0c06397fb26ab3a437d6a0d858d3b24e62855d82
|
|
/retest |
leogr
changed the title
ldegio
approved these changes
May 14, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR upgrades c-ares, protobuf and gRPC versions. It also changes the way we build gRPC when deps are bundled. The building of protobuf and c-ares is not delegated anymore to gRPC.
This PR also includes other changes (some required by the gRPC upgrade, some are just small improvements):
_usecurelibs to default onesno-shared--disable-sharedFinally, other changes are included to easier the libraries integration into the Falco build system, see also falcosecurity/falco#1552
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Unfortunately, this PR introduces a workaround, see https://github.com/falcosecurity/libs/pull/30/files#diff-80c09a7dee6a7fbc4e1648084e71598c7e28978e00ff50ab9381e7b8e20ec8b8R49
Since this PR took longer than expected and is blocking falcosecurity/falco#1552 I'd prefer to fix that later.
Does this PR introduce a user-facing change?: