-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read BPF license from ELF #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 83f9320effa113ae586161017264da7a1e376e81
|
/retest |
Signed-off-by: Leonardo Di Donato <[email protected]>
…or loading tracepoint BPF programs Signed-off-by: Leonardo Di Donato <[email protected]>
39fd150
to
3a30072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
🥳
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area driver-ebpf
/area libscap
What this PR does / why we need it:
While it is indeed correct that the license section is in the BPF probe source code (see 8918b95),
our custom BPF loader should read it by parsing the ELF and then accordingly use the read value in the
bpf_attr
instance.Which issue(s) this PR fixes:
Rather than always enforcing the license in the libscap loader - like the #37 attempt does - this PR reads the actual value from the ELF and then uses it in our custom loading phases (see
load_tracepoint
>bpf_load_program
)Special notes for your reviewer:
Supersedes #37
Does this PR introduce a user-facing change?: