-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SASL fields support for Kafka Logging Endpoint to dev-v2 branch #229
Closed
kellymclaughlin
wants to merge
24
commits into
fastly:dev-v2
from
kellymclaughlin:kelly/add-kafka-sasl-fields-dev-v2
Closed
Add SASL fields support for Kafka Logging Endpoint to dev-v2 branch #229
kellymclaughlin
wants to merge
24
commits into
fastly:dev-v2
from
kellymclaughlin:kelly/add-kafka-sasl-fields-dev-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* service waf component new API implemented
* waf version (configuration) API implemented
* WAF active rules implementation
* WAF rules related endpoints implementation
* create empty waf version endpoint implemented
* making WAF enable and disable functions consistent with rest
* Introducing waf version struct method to check for custom emptiness * Using pointers on the WAf version update endpoint
Setting go.mod module to v2
Add the following fields in order to support SASL: * parse_log_keyvals * auth_method * request_max_bytes * user * password
Integralist
force-pushed
the
dev-v2
branch
3 times, most recently
from
November 9, 2020 10:51
0c4ec09
to
530f1e8
Compare
Just a note to clarify, this PR is just a cherry-pick of the commits from #226 onto the |
Integralist
force-pushed
the
dev-v2
branch
2 times, most recently
from
November 16, 2020 11:26
b7ba895
to
b505e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following fields in order to support SASL: