Remove omitempty from SSLCheckCert field
#294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer noticed this when using our Terraform provider (and it actually caused an incident for them). This is a sad case but we need to be careful when setting
omitemptytag especially if our API setstrueas the default value.We could use a pointer instead, but in this particular case, I figured removing the
omitemptytag is a safer change for backward compatibility.Once this PR is merged and a new go-fastly version is released, I will make a separate PR on the Terraform provider repo to bump the current require version to the latest version, which also requires some minor changes related to the recent breaking changes in go-fastly.