-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove untested and undocumented interfaces #2084
Conversation
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
68f553a
to
bb948b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2084 +/- ##
==========================================
+ Coverage 83.32% 84.65% +1.32%
==========================================
Files 100 99 -1
Lines 8084 7877 -207
==========================================
- Hits 6736 6668 -68
+ Misses 1348 1209 -139
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
df4403f
to
0294315
Compare
@judahrand the only thing really blocking us from moving forward is the fact that some users have indicated that they do want to have feature table support. The current plan is still to remove feature tables, but I just want to make sure that we aren't missing anything. I think it may be worth discussing it at our next community call and making sure that the community is aware of this change (perhaps by sending out an email on the feast-dev mailing list) |
added this to next week's community call agenda |
0294315
to
e2e40bf
Compare
hey @judahrand thanks for following up here - Danny and Willem are both on vacation right now, let me try to confirm with them that we're okay to move forward with removing feature tables here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixwang9817 The result of our community call was that this was ok. We just need to send out a note to the community (esp to folks like Salesforce) as a heads up.
Thanks for also removing the outdated concepts docs! Removed some tech debt from Gitbook.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
e2e40bf
to
3eda26a
Compare
/lgtm |
What this PR does / why we need it:
This PR removes a bunch of things which no longer seem to be supported in Feast. They result in a bunch of tech debt which makes things harder to push forward. All the things removed were untested.
The documentation to migrate to Feast 0.10+ already exists here and explains that FeatureTables have been replaced with FeatureViews. Uses should have migrated by now.
Which issue(s) this PR fixes:
Fixes #1583
Does this PR introduce a user-facing change?: