Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove untested and undocumented interfaces #2084

Merged
merged 3 commits into from
Dec 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions docs/concepts/architecture.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/concepts/entities.md

This file was deleted.

122 changes: 0 additions & 122 deletions docs/concepts/feature-tables.md

This file was deleted.

123 changes: 0 additions & 123 deletions docs/concepts/feature-views.md

This file was deleted.

36 changes: 0 additions & 36 deletions docs/concepts/glossary.md

This file was deleted.

2 changes: 0 additions & 2 deletions docs/concepts/sources.md

This file was deleted.

26 changes: 0 additions & 26 deletions docs/concepts/stores.md

This file was deleted.

2 changes: 0 additions & 2 deletions sdk/python/feast/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from .feature import Feature
from .feature_service import FeatureService
from .feature_store import FeatureStore
from .feature_table import FeatureTable
from .feature_view import FeatureView
from .on_demand_feature_view import OnDemandFeatureView
from .repo_config import RepoConfig
Expand All @@ -36,7 +35,6 @@
"Feature",
"FeatureService",
"FeatureStore",
"FeatureTable",
"FeatureView",
"OnDemandFeatureView",
"RepoConfig",
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/data_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def date_partition_column(self, date_partition_column):
@abstractmethod
def from_proto(data_source: DataSourceProto) -> Any:
"""
Converts data source config in FeatureTable spec to a DataSource class object.
Converts data source config in protobuf spec to a DataSource class object.

Args:
data_source: A protobuf representation of a DataSource.
Expand Down
3 changes: 1 addition & 2 deletions sdk/python/feast/diff/FcoDiff.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from feast.base_feature_view import BaseFeatureView
from feast.entity import Entity
from feast.feature_service import FeatureService
from feast.feature_table import FeatureTable
from feast.protos.feast.core.Entity_pb2 import Entity as EntityProto
from feast.protos.feast.core.FeatureView_pb2 import FeatureView as FeatureViewProto

Expand Down Expand Up @@ -44,7 +43,7 @@ def add_fco_diff(self, fco_diff: FcoDiff):
self.fco_diffs.append(fco_diff)


T = TypeVar("T", Entity, BaseFeatureView, FeatureService, FeatureTable)
T = TypeVar("T", Entity, BaseFeatureView, FeatureService)


def tag_objects_for_keep_delete_add(
Expand Down
Loading