Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix go unit tests failure #3078

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 12, 2022

What this PR does / why we need it:
Unclear why tests passed before, but the Go unit tests run the Feast Python CLI, which relies on Python protos being built. The original make test-go command does not build those Python protos.

Which issue(s) this PR fixes:

Fixes #

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

Makefile Outdated
@@ -317,7 +317,7 @@ install-feast-ci-locally:

# Needs feast package to setup the feature store
# CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag
test-go: compile-protos-go compile-go-lib install-feast-ci-locally
test-go: compile-protos-python compile-protos-go compile-go-lib install-feast-ci-locally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

barf

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #3078 (06362c6) into master (4b1476f) will increase coverage by 8.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
+ Coverage   67.43%   75.93%   +8.49%     
==========================================
  Files         169      203      +34     
  Lines       14936    16839    +1903     
==========================================
+ Hits        10072    12786    +2714     
+ Misses       4864     4053     -811     
Flag Coverage Δ
integrationtests 67.29% <ø> (-0.14%) ⬇️
unittests 58.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/cassandra_online_store/cassandra_online_store.py 2.63% <0.00%> (ø)
.../contrib/postgres_offline_store/postgres_source.py 50.66% <0.00%> (ø)
sdk/python/feast/infra/utils/hbase_utils.py 41.17% <0.00%> (ø)
...k/python/feast/infra/materialization/lambda/app.py 26.66% <0.00%> (ø)
..._stores/contrib/postgres_offline_store/postgres.py 35.22% <0.00%> (ø)
...s/contrib/spark_offline_store/tests/data_source.py 40.42% <0.00%> (ø)
.../feature_repos/universal/online_store/cassandra.py 42.85% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Kevin Zhang <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 12, 2022
Signed-off-by: Kevin Zhang <[email protected]>
Signed-off-by: Kevin Zhang <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 0ed1a63 into feast-dev:master Aug 12, 2022
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Aug 13, 2022
* ci: Fix go unit tests failure

Signed-off-by: Danny Chiao <[email protected]>

* Temporary fix?

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Kevin Zhang <[email protected]>
Co-authored-by: Kevin Zhang <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
adchia added a commit that referenced this pull request Aug 15, 2022
* ci: Fix go unit tests failure

Signed-off-by: Danny Chiao <[email protected]>

* Temporary fix?

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Kevin Zhang <[email protected]>
Co-authored-by: Kevin Zhang <[email protected]>
adchia added a commit that referenced this pull request Aug 15, 2022
* ci: Fix go unit tests failure

Signed-off-by: Danny Chiao <[email protected]>

* Temporary fix?

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Kevin Zhang <[email protected]>
Co-authored-by: Kevin Zhang <[email protected]>
@adchia adchia deleted the fixGoTests branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants