Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix go unit tests failure #3078

Merged
merged 4 commits into from
Aug 12, 2022
Merged

ci: Fix go unit tests failure #3078

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
375ede3
ci: Fix go unit tests failure
adchia Aug 12, 2022
42ebc7a
Temporary fix?
kevjumba Aug 12, 2022
8ca783b
Fix
kevjumba Aug 12, 2022
06362c6
Fix
kevjumba Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ install-go-ci-dependencies:
python -m pip install pybindgen==0.22.0 protobuf==3.20.1

install-protoc-dependencies:
pip install grpcio-tools==1.47.0 mypy-protobuf==3.1.0
pip install --ignore-installed protobuf grpcio-tools==1.47.0 mypy-protobuf==3.1.0

compile-protos-go: install-go-proto-dependencies install-protoc-dependencies
python setup.py build_go_protos
Expand All @@ -317,7 +317,7 @@ install-feast-ci-locally:

# Needs feast package to setup the feature store
# CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag
test-go: compile-protos-go compile-go-lib install-feast-ci-locally
test-go: compile-protos-go compile-protos-python compile-go-lib install-feast-ci-locally
CGO_LDFLAGS_ALLOW=".*" go test -tags cgo,ccalloc ./...

format-go:
Expand Down