New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing '[]' for key list #236

Closed

windoze opened this issue May 9, 2022 · 0 comments

Member

windoze commented May 9, 2022

The key field should be an array instead of a comma separated string.
https://github.com/linkedin/feathr/blob/ff66b2a3cd4966f8e79aa0e7f92b705f1eede46d/feathr_project/feathr/query_feature_list.py#L24

Corresponding Scala code reading this value is at:
https://github.com/linkedin/feathr/blob/ff66b2a3cd4966f8e79aa0e7f92b705f1eede46d/src/main/scala/com/linkedin/feathr/offline/config/FeatureJoinConfig.scala#L56

The text was updated successfully, but these errors were encountered:

windoze added a commit that referenced this issue


          #236 Missing brackets

a29828f

windoze mentioned this issue

#236 Missing brackets #237

Merged

xiaoyongzhu pushed a commit that referenced this issue


          #236 Missing brackets (#237)

12cc053

xiaoyongzhu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment