Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#236 Missing brackets #237

Merged
merged 2 commits into from
May 10, 2022
Merged

#236 Missing brackets #237

merged 2 commits into from
May 10, 2022

Conversation

windoze
Copy link
Member

@windoze windoze commented May 9, 2022

#236

Missing brackets in the feature join config template.

@windoze windoze added the safe to test Tag to execute build pipeline for a PR from forked repo label May 9, 2022
@xiaoyongzhu xiaoyongzhu requested a review from jaymo001 May 9, 2022 16:41
hangfei
hangfei approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we also add a test to cover this?

@xiaoyongzhu xiaoyongzhu merged commit 12cc053 into main May 10, 2022
@xiaoyongzhu xiaoyongzhu deleted the windoze/236-missing-bracket branch August 22, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@hangfei hangfei hangfei approved these changes

@jaymo001 jaymo001 Awaiting requested review from jaymo001

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windoze @xiaoyongzhu @hangfei