Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX - USE GITFLOW] Update commissioner listing on homepage and leadership landing page #3131

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Aug 27, 2019

Summary

Impacted areas of the application

List general components of the application that this PR will affect:

  • Homepage

Screenshots

Screen Shot 2019-08-27 at 2 09 05 PM

How to test

  • Checkout branch
  • ./manage.py runserver
  • Ensure that the HTML on the homepage reflects the commissioner change accurately. http://localhost:8000/
  • Go to the leadership and structure page here: http://localhost:8000/about/leadership-and-structure/
  • Ensure that if a Chair and Vice Chair are populated that it will put those first. Otherwise show commissioners in alpha by last name

@patphongs patphongs added the HOTFIX Merge with git flow label Aug 27, 2019
@patphongs patphongs requested a review from rfultz August 27, 2019 19:10
@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #3131 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
- Coverage   74.76%   74.69%   -0.08%     
==========================================
  Files         119      119              
  Lines        7158     7165       +7     
  Branches      633      633              
==========================================
  Hits         5352     5352              
- Misses       1806     1813       +7
Impacted Files Coverage Δ
fec/home/templatetags/commissioners.py 33.33% <0%> (-21.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6d803...6333d42. Read the comment docs.

Copy link
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to do anything about his page? /about/leadership-and-structure/mathew-s-petersen/ (Also, his page's slug is misspelled.)

@patphongs
Copy link
Member Author

patphongs commented Aug 27, 2019

oh good point @rfultz, we can put in a wagtail redirect for the misspelled slug and update the page name. I'll document that in this ticket #3128, which the content team will take care of on 9/3.

@patphongs patphongs changed the title [HOTFIX - USE GITFLOW] Update commissioner listing on homepage [HOTFIX - USE GITFLOW] Update commissioner listing on homepage and leadership landing page Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOTFIX Merge with git flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants