Update Vice chair title on homepage, make it so this is auto-updates in the future.

[johnnyporkchops]

Summary

• This adds an argument to the commissioners.py templatetag so it can be used in multiple locations including the home page commissioners' listing.

• With this PR, the homepage commissioner listing will be updated automatically when their Wagtail commissioner page is edited (as on leadership-and-structure and leadership-and-structure/commissioners ). We were currently hardcoding html for home page commissioners' display.

• Added comments to explain how to use the argument to control the grid layout of the rendered templatetag ( i.e : 2 grid or 3 grid layout )

• Resolves Update home page and Leadership page to reflect Vice Chair's title #3308

Impacted areas of the application

This impacts the commissioners block that appears in streamfields (currently used on about/leadership-and-structure ). Also effects the homepage commissioners' listing.

• modified: home/templates/home/home_page.html
• modified: home/templates/partials/current-commissioners.html
• modified: home/templatetags/home_page.py
• modified: home/templates/blocks/commissioners.html

Looks exactly the same as on production, but its not hardcoded:

• Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface or front end change, include both a Before and After screenshot.

Related PRs

• The current PR takes work done in this PR ([HOTFIX - USE GITFLOW] Update commissioner listing on homepage and leadership landing page #3131) one step further by using the templaterag logic on the homepage as well.
  https://github.com/fecgov/fec-cms/pull/3131/files#
• The above related-PR was an enhancement to the logic for this PR (Vacant commissioners #963 )to capture term expiration dates and remove commissioners no longer active in addition to vacant seats(I think)

How to test

• Checkout and run branch
• Verify that the homepage commissioner listing for Vice Chair Hunter includes her title and that others are correct. (Your local Wagtail page for Hunter must have her title added if it is not already)
• You may not see the images if you do not have them on your local CMS, you can add the these three images to fec-cms/fec/media/images
  
  
  

---

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (develop@b396f37). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             develop    #3310   +/-   ##
==========================================
  Coverage           ?   74.61%           
==========================================
  Files              ?      120           
  Lines              ?     7232           
  Branches           ?      633           
==========================================
  Hits               ?     5396           
  Misses             ?     1836           
  Partials           ?        0

Impacted Files	Coverage Δ
fec/home/templatetags/commissioners.py	33.33% <ø> (ø)
fec/home/templatetags/home_page.py	37.5% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b396f37...29ccda4. Read the comment docs.

[dorothyyeager]

@johnnyporkchops I'm not sure this worked. I added Vice Chair to the Commissioner's page in feature, but it did not update the home page automatically to reflect her title. (We've already added her title to her page in prod.) We need to ensure the home page says she is the Vice Chair.

[rfultz]

Seems to be working for me locally!

[johnnyporkchops]

@dorothyyeager this is not on feature, so it would not work there. I guess there is no way for you to review it but I thought you should be on as a reviewer since it was your issue

[lbeaufort]

Just a reminder that if this is going to be a hotfix, we should make a new branch off master. We could cherry-pick these commits over if it's easier.

[dorothyyeager]

Approved content team wise but not merging. Will need a dev to doublecheck and merge to master.

[johnnyporkchops]

Closing in favor of hotfix: #3315

[lbeaufort]

New hotfix PR was made: #3315