Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on nose #448

Merged

Conversation

jeremycline
Copy link
Member

Now that we use pytest, we should not depend on nose.

Signed-off-by: Jeremy Cline [email protected]

Now that we use pytest, we should not depend on nose.

Signed-off-by: Jeremy Cline <[email protected]>
@codecov-io
Copy link

codecov-io commented Jul 13, 2017

Codecov Report

Merging #448 into develop will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
- Coverage    55.81%   55.65%   -0.16%     
===========================================
  Files           31       31              
  Lines         1917     1917              
  Branches       301      301              
===========================================
- Hits          1070     1067       -3     
- Misses         751      754       +3     
  Partials        96       96
Impacted Files Coverage Δ
fedmsg/replay/__init__.py 32.39% <0%> (-2.82%) ⬇️
fedmsg/meta/__init__.py 70.76% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2028f...3e66d34. Read the comment docs.

@pypingou
Copy link
Member

Looks fine to me

@jeremycline jeremycline merged commit 4fe9558 into fedora-infra:develop Jul 14, 2017
@jeremycline jeremycline deleted the remove-nose-dependency branch July 14, 2017 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants