Add Python 3 support to fedmsg #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice and clean, looks fine to me! :) |
|
I believe this also depends on #448 since with nose the tests hang on Python 3. I was working off that branch and rebased before I made this PR. I don't know why nose causes the tests to hang on Python 3, though :( |
Codecov Report
@@ Coverage Diff @@
## develop #449 +/- ##
==========================================
+ Coverage 55.36% 55.9% +0.53%
==========================================
Files 30 30
Lines 1853 1853
Branches 285 306 +21
==========================================
+ Hits 1026 1036 +10
+ Misses 739 732 -7
+ Partials 88 85 -3
Continue to review full report at Codecov.
|
Signed-off-by: Jeremy Cline <[email protected]>
pyzmq requires bytes, not text. Signed-off-by: Jeremy Cline <[email protected]>
This function is intended to modify the signature and certificate to match m2crypto's format just before sending the message. As such, it works on the encoded version of both. Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
Calling decode('base64') is not supported on Python 3 strings.
Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
Signed-off-by: Jeremy Cline <[email protected]>
Amusingly, these tests have always passed in CI because it's been quietly downloading the CA which didn't sign the certificate either. We shouldn't rely on the network, though. Signed-off-by: Jeremy Cline <[email protected]>
|
Okay, I had to tweak a few more things to get CI passing, so it probably wouldn't hurt for this to get a second look. |
|
Still looking good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Python 3 support to fedmsg. Tests are run against 3.4+.