Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 2.6 support #469

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Remove Python 2.6 support #469

merged 1 commit into from
Aug 17, 2017

Conversation

jeremycline
Copy link
Member

See #418 and mokshaproject/moksha#48.

Signed-off-by: Jeremy Cline [email protected]

@codecov
Copy link

codecov bot commented Aug 16, 2017 •
edited
Loading

Codecov Report

Merging #469 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
- Coverage    58.92%   58.82%   -0.11%     
===========================================
  Files           29       29              
  Lines         1831     1831              
  Branches       303      303              
===========================================
- Hits          1079     1077       -2     
- Misses         665      667       +2     
  Partials        87       87
Impacted Files Coverage Δ
fedmsg/crypto/utils.py 58.46% <0%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bc6df...5c6b3b2. Read the comment docs.

pypingou
pypingou approved these changes Aug 17, 2017
View reviewed changes
Copy link
Member

@pypingou pypingou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a conflict with #470 but easy enough to fix.

👍 for me

doc/changelog.rst Outdated
Backwards incompatible changes
------------------------------

* Python 2.6 is no longer supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will conflict with #470

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured this way I'd be forced to write the release note instead of putting it off until I want to tag the release 😄

@jeremycline
Remove Python 2.6 support
5c6b3b2 
Signed-off-by: Jeremy Cline <[email protected]>
@jeremycline
Copy link
Member Author

Not sure what the deal is with codecov here, the report I generate locally shows that line as covered and there's no reason I can see that that code only would have been exercised in Python 2.6 alone.

@jeremycline jeremycline merged commit d7da47f into fedora-infra:develop Aug 17, 2017
@jeremycline jeremycline deleted the remove-py26 branch August 17, 2017 19:20
@jeremycline jeremycline mentioned this pull request Aug 17, 2017
Closed
@frenzymadness
Copy link
Contributor

Perfect work! Side note: The specfile should be also modified. Should I create a bug in bugzilla?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pypingou pypingou pypingou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremycline @frenzymadness @pypingou