Python 3 compatibility for moksha.hub #48
Conversation
|
Tests failed so I reverted Python 3 related changes in .travis.yml file. But now, tests are failing again because Twisted needs at least Python 2.7. Nevertheless, both problems mentioned above are not related to moksha.hub module. I'm attaching test results of moksha.hub for Python 2 and Python 3. (2.7.13 and 3.6.1). From my point of view everything looks good and the changes could be merged and new version released. Let me know, what do you think about it. Have a nice day. |
frenzymadness
changed the title
exceptions handling.
Python 3 compatibility.
For some reason, in Python 3, values from config file are not replaced by default values given to constructor. It means that for example %(here)s is not replaced by path to folder with config file and `EnvironmentConfigParser._interpolate()` is trying to find this name in environment variables. This fix is based on manual look into ConfigParser defaults and manual replacing default values in case they are not in environment variables.
DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
necessary to decode output to utf-8.
|
It looks good from my perspective, thanks! I proposed in fedora-infra/fedmsg#418 that we drop Python 2.6 support in fedmsg after 0.19 - @ralphbean how do you feel about that and also dropping 2.6 here? |
👍 🛰️ |
|
Perfect. Let's merge it and ship it in a new release, if possible. |
|
The releases are up on pypi now and I'm doing (non python3-repackaged) builds for rawhide. @frenzymadness, or @jeremycline: do either of you want to take on the spec file changes? |
|
If @frenzymadness is willing to do it, I definitely won't turn down the help 😃. Otherwise, I can do it when I make the spec file changes for fedmsg. |
|
Hello. |
Hello.
I am making moksha.hub module Python 3 compatible For now, all tests are passing with Python 2 and Python 3.
This PR is still WIP but reviews are welcome.
Will see what will happen in Travis with Python 3 enabled.
Have a nice day.
Lumír