-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): use a Vue key so file paths update correctly #389
Conversation
|
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7c30044
to
88dc969
Compare
88dc969
to
e7b4f45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thank you!
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-plugin-checker | 0.7.2 | 0.8.0 | ## [v0.8.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.8.0) ##### 🚨 Breaking Changes - **vue-tsc**: Updated createVueLanguagePlugin syntax, version pin - by [@daniluk4000](https://github.com/daniluk4000) and **drodichkin** in fi3ework/vite-plugin-checker#398 [<samp>(5f5b9)</samp>](fi3ework/vite-plugin-checker@5f5b92a) Now, vite-plugin-checker requires `"vue-tsc": "~2.1.6"`. ##### 🚀 Features - Advance typescript teminal consolelog text color - by [@jaceechan](https://github.com/jaceechan) in fi3ework/vite-plugin-checker#393 [<samp>(aa3d4)</samp>](fi3ework/vite-plugin-checker@aa3d413) ##### 🐞 Bug Fixes - **ui**: Use a Vue key so file paths update correctly - by [@artursapek](https://github.com/artursapek) in fi3ework/vite-plugin-checker#389 [<samp>(fcbb6)</samp>](fi3ework/vite-plugin-checker@fcbb687) ##### [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.8.0)
this fixes a bug with this plugin where the file paths & line numbers don't update correctly after a hot reload. the error message for each entry does update while the file paths confusingly don't, therefore creating an incorrect list of errors.