Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use a Vue key so file paths update correctly #389

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

artursapek
Copy link
Contributor

this fixes a bug with this plugin where the file paths & line numbers don't update correctly after a hot reload. the error message for each entry does update while the file paths confusingly don't, therefore creating an incorrect list of errors.

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: e7b4f45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit e7b4f45
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/66d9ed3bf5f8e600080f57a1
😎 Deploy Preview https://deploy-preview-389--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework changed the title use a Vue key so file paths update correctly fix(ui): use a Vue key so file paths update correctly Sep 5, 2024
Copy link
Owner

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@fi3ework fi3ework merged commit fcbb687 into fi3ework:main Sep 5, 2024
7 of 8 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Sep 6, 2024
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-plugin-checker | 0.7.2 | 0.8.0 |


## [v0.8.0](https://github.com/fi3ework/vite-plugin-checker/releases/tag/vite-plugin-checker%400.8.0)

#####    🚨 Breaking Changes

-   **vue-tsc**: Updated createVueLanguagePlugin syntax, version pin  -  by [@daniluk4000](https://github.com/daniluk4000) and **drodichkin** in fi3ework/vite-plugin-checker#398 [<samp>(5f5b9)</samp>](fi3ework/vite-plugin-checker@5f5b92a)

    Now, vite-plugin-checker requires `"vue-tsc": "~2.1.6"`.

#####    🚀 Features

-   Advance typescript teminal consolelog text color  -  by [@jaceechan](https://github.com/jaceechan) in fi3ework/vite-plugin-checker#393 [<samp>(aa3d4)</samp>](fi3ework/vite-plugin-checker@aa3d413)

#####    🐞 Bug Fixes

-   **ui**: Use a Vue key so file paths update correctly  -  by [@artursapek](https://github.com/artursapek) in fi3ework/vite-plugin-checker#389 [<samp>(fcbb6)</samp>](fi3ework/vite-plugin-checker@fcbb687)

#####     [View changes on GitHub](https://github.com/fi3ework/vite-plugin-checker/compare/[email protected]@0.8.0)
@artursapek artursapek deleted the add-diagnostic-key branch October 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants