fevm_test: delegate call test #10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compile the .sol solidity files to .hex, add sharable methods into kit/evm
|
@snissn Thanks for reopening!
@shrenujbansal Can you please continue this conversation here? |
|
I'm a +=1 not a ++ kind of guy what can i say :) but i'll yield to the golinter for now -- pushed a commit to address both of your comments @arajasek |
magik6k
reviewed
Jan 17, 2023
Comment on lines
+29
to
+32
| fromId, err := client.StateLookupID(ctx, from, types.EmptyTSK) | ||
| require.NoError(t, err) | ||
|
|
||
| senderEthAddr, err := ethtypes.EthAddressFromFilecoinAddress(fromId) |
There was a problem hiding this comment.
Not sure if the client.StateLookupID is needed, but I guess this works either way in itests.
7 tasks
20 tasks
magik6k
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/ref-fvm#1320
Proposed Changes
refactor of fevm_test, addition of delegate call test and a script to compile the .sol solidity files to .hex
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps