fevm_test: delegate call test #9990

snissn · 2023-01-12T04:43:40Z

…

Related Issues

filecoin-project/ref-fvm#1320

Proposed Changes

refactor of fevm_test, addition of delegate call test and a script to compile the .sol solidity files to .bin'

Checklist

Before you mark the PR ready for review, please make sure that:

Commits have a clear commit message.
PR title is in the form of of <PR type>: <area>: <change being made>
- example: fix: mempool: Introduce a cache for valid signatures
- PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
- area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
New features have usage guidelines and / or documentation updates in
- Lotus Documentation
- Discussion Tutorials
Tests exist for new functionality or change in behavior
CI is green

This reverts commit ea73fd5.

Co-authored-by: Raúl Kripalani <[email protected]>

To include filecoin-project/go-jsonrpc#83.

Co-authored-by: Raúl Kripalani <[email protected]>

Make it use GasEstimateMessageGas, which applies overestimation by default. This accounts for inclusion costs.

Also updates the actors to accommodate this change, and fix a bug in looking up addresses for f4 actors.

Co-authored-by: Raúl Kripalani <[email protected]>

We need to add full FEVM state support, but that will require merging master. This is enough for now. fixes filecoin-project/ref-fvm#1022

itests: Eth JSON-RPC: EthGetBlockByHash and EthGetBlockByNumber

…leases/tag/dev%2F20230109-prehyperspace

feat: network: introduce hyperspace :integrate the new bundle type

* Add tests for eth get balance and transaction submits * fix lint * one more lint * Add contract invocation test * address comments * fix lint * address final comment * make gen and fix lint as always

… compile the .sol solidity files to .bin

…ere effected

snissn · 2023-01-12T04:47:35Z

ci/circleci: lint-all and ci/circleci: test-itest-eth_transactions seem to be failing from commit #3456d90e0d which is unrelated to this PR

ci/circleci: test-itest-fevm failed due to an SSL error unrelated to this commit and should be rerun by someoine with the correct permissions

curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104
[download_release_tarball] failed to download release asset 
+ return 1

shrenujbansal · 2023-01-12T17:20:47Z

itests/fevm_test.go

+	inputData := append(inputDataContract, inputDataValue...)
+
+	result := invokeContract(t, ctx, client, fromAddr, storageAddr, "setVars(address,uint256)", inputData)
+	expectedResult, err := hex.DecodeString("0000000000000000000000000000000000000000000000000000000000000007")


A comment specifying what this byte string means would be helpful

ty! will add

shrenujbansal · 2023-01-12T17:23:55Z

itests/fevm_test.go

+	fromId, err := client.StateLookupID(ctx, from, types.EmptyTSK)
+	require.NoError(t, err)
+
+	senderEthAddr, err := ethtypes.EthAddressFromFilecoinAddress(fromId)


fromId is going to be an ID address and this API will always give you an 0xff eth address which isn't always accurate if we have an f4 address available

sorry i am new don't understand this yet - should i make any changes?

shrenujbansal · 2023-01-12T17:25:28Z

itests/contracts/SimpleCoin.bin

@@ -1 +1 @@
-608060405234801561001057600080fd5b506127106000803273ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000208190555061051c806100656000396000f3fe608060405234801561001057600080fd5b50600436106100415760003560e01c80637bd703e81461004657806390b98a1114610076578063f8b2cb4f146100a6575b600080fd5b610060600480360381019061005b919061030a565b6100d6565b60405161006d9190610350565b60405180910390f35b610090600480360381019061008b9190610397565b6100f4565b60405161009d91906103f2565b60405180910390f35b6100c060048036038101906100bb919061030a565b61025f565b6040516100cd9190610350565b60405180910390f35b600060026100e38361025f565b6100ed919061043c565b9050919050565b6000816000803373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000205410156101455760009050610259565b816000803373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000206000828254610193919061047e565b92505081905550816000808573ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff16815260200190815260200160002060008282546101e891906104b2565b925050819055508273ffffffffffffffffffffffffffffffffffffffff163373ffffffffffffffffffffffffffffffffffffffff167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef8460405161024c9190610350565b60405180910390a3600190505b92915050565b60008060008373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001908152602001600020549050919050565b600080fd5b600073ffffffffffffffffffffffffffffffffffffffff82169050919050565b60006102d7826102ac565b9050919050565b6102e7816102cc565b81146102f257600080fd5b50565b600081359050610304816102de565b92915050565b6000602082840312156103205761031f6102a7565b5b600061032e848285016102f5565b91505092915050565b6000819050919050565b61034a81610337565b82525050565b60006020820190506103656000830184610341565b92915050565b61037481610337565b811461037f57600080fd5b50565b6000813590506103918161036b565b92915050565b600080604083850312156103ae576103ad6102a7565b5b60006103bc858286016102f5565b92505060206103cd85828601610382565b9150509250929050565b60008115159050919050565b6103ec816103d7565b82525050565b600060208201905061040760008301846103e3565b92915050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fd5b600061044782610337565b915061045283610337565b925082820261046081610337565b915082820484148315176104775761047661040d565b5b5092915050565b600061048982610337565b915061049483610337565b92508282039050818111156104ac576104ab61040d565b5b92915050565b60006104bd82610337565b91506104c883610337565b92508282019050808211156104e0576104df61040d565b5b9291505056fea26469706673582212205ede41ff9072784ccc19ac18de0781558d305a8139361fa85dc51a8614e47d8c64736f6c63430008110033


Why did this change?

I re-ran solidity compiler and don't know exactly how the previous binary file was compiled ie version of solidity and optimization settings. maybe ideally each test run should create a new .bin binary and these don't need to be in the repo, but i'm not sure the best way to package the solc compiler and there isn't a clean go binding

shrenujbansal · 2023-01-12T17:34:47Z

itests/fevm_test.go


-		inputData, err := hex.DecodeString("000000000000000000000000ff00000000000000000000000000000000000064")
-		require.NoError(t, err)
+func invokeContract(t *testing.T, ctx context.Context, client *kit.TestFullNode, fromAddr address.Address, idAddr address.Address, funcSignature string, inputData []byte) []byte {


As @arajasek mentioned, it would be nice to make these helpers available to other tests

…the data

…ename, not to the contract name as we add more tests this will be more important

snissn · 2023-01-13T16:46:11Z

can i have a suggestion on:

how / where to put the helpers available to other tests?
fromId is going to be an ID address and this API will always give you an 0xff eth address which isn't always accurate if we have an f4 address available

arajasek · 2023-01-13T19:22:10Z

@snissn I'd suggest moving install contract to live in here as a more comprehensive version of DeployContract. I think it'll save some boilerplate in both existing and future tests.

I'm not sure which of the other methods are worth moving there. I'd say let's leave them where they are for now, and export them as we write more tests (and find a need for them).

vyzo and others added 30 commits November 9, 2022 19:30

add --hex option to create-evm-actor

b9ed239

fix: EthGetTransactionCount should not return error

ccbf571

Revert "fix: EthGetTransactionCount should not return error"

2741c96

This reverts commit ea73fd5.

fix: EthGetTransactionCount should not return error

16ee7d0

fix lint

e109be4

fix(api): eth/id address conversion (#9511)

420bd34

Eth JSON-RPC API: support f4 addresses.

17e9e97

add support for f4 addresses in the Eth JSON-RPC and signature.

98e534c

Eth JSON-RPC API: Add EAM as contract creator (#9528)

7e7fff1

genesis: instantiate EAM at id 10.

57a515f

Eth TX Encoding (#9531)

aa0e6c1

feat: use f4 eth addresses wherever possible (#9532)

56b2389

Co-authored-by: Raúl Kripalani <[email protected]>

api: ethrpc: fix eth_getCode, eth_getTransactionReceipt (#9530)

e17e927

hack: allow sending from f4 addresses (#9533)

7f81780

fix: evm: decode params/return in cli (#9536)

98e7623

fix lotus state evm commands to use EAM.

0cff785

fixes to Eth JSON-RPC API.

a58e87b

update go-jsonrpc dependency.

c0cbcda

To include filecoin-project/go-jsonrpc#83.

api: ethrpc: implement eth_feeHistory (#9539)

64afdfc

Co-authored-by: Raúl Kripalani <[email protected]>

fix signature validation logic.

9017e5d

fix address recovery from pubkey.

6d5ec6a

make eth_getCode return nil if the target is not an EVM smart contract.

323ff1b

fix eth_feeHistory: add missing param.

32617a6

fix message sending logic.

ab5f021

fix gas estimation.

78dd7a2

Make it use GasEstimateMessageGas, which applies overestimation by default. This accounts for inclusion costs.

fix eth_feeHistory.

dc5fc9d

fix: evm: use CREATE not CREATE2 for EVM contract deployment (#9553)

6337d59

Also updates the actors to accommodate this change, and fix a bug in looking up addresses for f4 actors.

fix: allow deploying from f1/f3 accounts (#9554)

ea54499

Co-authored-by: Raúl Kripalani <[email protected]>

fix: avoid returning an error when getting embryo state (#9550)

b3b9da5

We need to add full FEVM state support, but that will require merging master. This is enough for now. fixes filecoin-project/ref-fvm#1022

fix: allow EthCall.From to be nil (#9556)

49da019

ychiaoli18 and others added 12 commits January 8, 2023 17:31

Merge pull request #9955 from filecoin-project/itest/eth-block

402173e

itests: Eth JSON-RPC: EthGetBlockByHash and EthGetBlockByNumber

add hyperspacenet

f05d3d8

add bundle from https://github.com/filecoin-project/builtin-actors/re…

370c8ad

…leases/tag/dev%2F20230109-prehyperspace

get hyperspace cids

72c04ca

update embryo to placehodler

cb49edf

Update to FVM 3.0.0-alpha.18

38c3ab2

Fixup multisig_test

06584bb

Update to go-state-types v0.10.0-alpha-9

1046b30

Merge pull request #9978 from filecoin-project/jen/hyper

95501b7

feat: network: introduce hyperspace :integrate the new bundle type

itests: Add tests for eth get balance and transaction submits (#9966)

3456d90

* Add tests for eth get balance and transaction submits * fix lint * one more lint * Add contract invocation test * address comments * fix lint * address final comment * make gen and fix lint as always

refactor of fevm_test, addition of delegate call test and a script to…

059bb28

… compile the .sol solidity files to .bin

more specific name from setup to setupFEVMTest because other itests w…

edfc0fc

…ere effected

snissn requested a review from a team as a code owner January 12, 2023 04:43

shrenujbansal reviewed Jan 12, 2023

View reviewed changes

snissn added 4 commits January 12, 2023 19:44

add comment explaining the decode string and test

baba2e2

add getter methods to solidity and use them via the test to validate …

e270b79

…the data

add new compile version

87a0083

add more complex compile command because we want to output to the fil…

cce2148

…ename, not to the contract name as we add more tests this will be more important

Base automatically changed from feat/nv18-fevm to release/v1.20.0 January 13, 2023 19:11

snissn marked this pull request as draft January 14, 2023 01:12

refactor fevm_test.go to add sharable methods into kit/evm

e9dcf8d

snissn closed this Jan 14, 2023

snissn deleted the snissn/delegatecalltest branch January 14, 2023 07:19

arajasek mentioned this pull request Jan 16, 2023

fevm_test: delegate call test #10010

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fevm_test: delegate call test #9990

fevm_test: delegate call test #9990

snissn commented Jan 12, 2023 •

edited

Loading

snissn commented Jan 12, 2023 •

edited

Loading

shrenujbansal Jan 12, 2023

snissn Jan 12, 2023

shrenujbansal Jan 12, 2023

snissn Jan 13, 2023

shrenujbansal Jan 12, 2023

snissn Jan 12, 2023

shrenujbansal Jan 12, 2023

snissn commented Jan 13, 2023

arajasek commented Jan 13, 2023

		@@ -1 +1 @@
		608060405234801561001057600080fd5b506127106000803273ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000208190555061051c806100656000396000f3fe608060405234801561001057600080fd5b50600436106100415760003560e01c80637bd703e81461004657806390b98a1114610076578063f8b2cb4f146100a6575b600080fd5b610060600480360381019061005b919061030a565b6100d6565b60405161006d9190610350565b60405180910390f35b610090600480360381019061008b9190610397565b6100f4565b60405161009d91906103f2565b60405180910390f35b6100c060048036038101906100bb919061030a565b61025f565b6040516100cd9190610350565b60405180910390f35b600060026100e38361025f565b6100ed919061043c565b9050919050565b6000816000803373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000205410156101455760009050610259565b816000803373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000206000828254610193919061047e565b92505081905550816000808573ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff16815260200190815260200160002060008282546101e891906104b2565b925050819055508273ffffffffffffffffffffffffffffffffffffffff163373ffffffffffffffffffffffffffffffffffffffff167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef8460405161024c9190610350565b60405180910390a3600190505b92915050565b60008060008373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001908152602001600020549050919050565b600080fd5b600073ffffffffffffffffffffffffffffffffffffffff82169050919050565b60006102d7826102ac565b9050919050565b6102e7816102cc565b81146102f257600080fd5b50565b600081359050610304816102de565b92915050565b6000602082840312156103205761031f6102a7565b5b600061032e848285016102f5565b91505092915050565b6000819050919050565b61034a81610337565b82525050565b60006020820190506103656000830184610341565b92915050565b61037481610337565b811461037f57600080fd5b50565b6000813590506103918161036b565b92915050565b600080604083850312156103ae576103ad6102a7565b5b60006103bc858286016102f5565b92505060206103cd85828601610382565b9150509250929050565b60008115159050919050565b6103ec816103d7565b82525050565b600060208201905061040760008301846103e3565b92915050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fd5b600061044782610337565b915061045283610337565b925082820261046081610337565b915082820484148315176104775761047661040d565b5b5092915050565b600061048982610337565b915061049483610337565b92508282039050818111156104ac576104ab61040d565b5b92915050565b60006104bd82610337565b91506104c883610337565b92508282019050808211156104e0576104df61040d565b5b9291505056fea26469706673582212205ede41ff9072784ccc19ac18de0781558d305a8139361fa85dc51a8614e47d8c64736f6c63430008110033

fevm_test: delegate call test #9990

fevm_test: delegate call test #9990

Conversation

snissn commented Jan 12, 2023 • edited Loading

Related Issues

Proposed Changes

Checklist

snissn commented Jan 12, 2023 • edited Loading

shrenujbansal Jan 12, 2023

Choose a reason for hiding this comment

snissn Jan 12, 2023

Choose a reason for hiding this comment

shrenujbansal Jan 12, 2023

Choose a reason for hiding this comment

snissn Jan 13, 2023

Choose a reason for hiding this comment

shrenujbansal Jan 12, 2023

Choose a reason for hiding this comment

snissn Jan 12, 2023

Choose a reason for hiding this comment

shrenujbansal Jan 12, 2023

Choose a reason for hiding this comment

snissn commented Jan 13, 2023

arajasek commented Jan 13, 2023

snissn commented Jan 12, 2023 •

edited

Loading

snissn commented Jan 12, 2023 •

edited

Loading