This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
call validate caller #379
Merged
call validate caller #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
approved these changes
May 14, 2020
zixuanzh
reviewed
May 14, 2020
| @@ -90,6 +90,7 @@ func (a Actor) AddVerifiedClient(rt vmr.Runtime, params *AddVerifiedClientParams | |||
| if params.Allowance.LessThanEqual(MinVerifiedDealSize) { | |||
| rt.Abortf(exitcode.ErrIllegalArgument, "Allowance %d below MinVerifiedDealSize for add verified client %v", params.Allowance, params.Address) | |||
| } | |||
| rt.ValidateImmediateCallerAcceptAny() | |||
There was a problem hiding this comment.
this looks like a temporary fix for launch but caller verification should be moved up from L99-104, thanks!
There was a problem hiding this comment.
@zixuanzh unfortunately that doesnt count as 'caller validation' for the purposes of the runtime. Its some weird restriction the spec team wants here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.