Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

call validate caller #379

Merged
merged 1 commit into from
May 14, 2020
Merged

call validate caller #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actors/builtin/verifreg/verified_registry_actor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ func (a Actor) AddVerifiedClient(rt vmr.Runtime, params *AddVerifiedClientParams
if params.Allowance.LessThanEqual(MinVerifiedDealSize) {
rt.Abortf(exitcode.ErrIllegalArgument, "Allowance %d below MinVerifiedDealSize for add verified client %v", params.Allowance, params.Address)
}
rt.ValidateImmediateCallerAcceptAny()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a temporary fix for launch but caller verification should be moved up from L99-104, thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zixuanzh unfortunately that doesnt count as 'caller validation' for the purposes of the runtime. Its some weird restriction the spec team wants here.


var st State
rt.State().Transaction(&st, func() interface{} {
Expand Down