Improve performance of watcher #6012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hez2010
commented
Sep 2, 2021
| } | ||
| } | ||
| } | ||
| }); | ||
| } | ||
| finally |
There was a problem hiding this comment.
There's not supposed to be exception here, but should we catch in case?
hez2010
force-pushed
the
watcher-imp
branch
3 times, most recently
from
df3a9a2 to
809331b
Compare
2 tasks
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of Changes
File creation is usually a combination of creation (creating a file handle) and modification (writing initial content), given that
UpdateFileOrFolderAsyncis slow, we introduced performance regression unexpectedly in #5992. This PR aims to resolve the performance issue ofUpdateFileOrFolderAsync.Validation
How did you test these changes?
Screenshots (optional)
Before:
before.mp4
After:
after.mp4