Skip to content

Commit

Permalink
Remove unnecessary error from retryOnTimeoutActivity
Browse files Browse the repository at this point in the history
What changed?
Removed unnecessary error from retryOnTimeoutActivity from canary/retry.go workflow

Why?
The error was introduced because there was a bug in the service that would allow completion from a previous attempt. The bug has been corrected.

How did you test it?
Executed the workflow without the error and confirmed that it completed successfully.

Potential risks

Release notes

Documentation Changes
  • Loading branch information
fimanishi committed Aug 27, 2024
1 parent 6ba8ad8 commit 8345cc7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions canary/retry.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ func retryOnTimeoutActivity(ctx context.Context, scheduledTimeNanos int64) (int,
if info.Attempt < 3 {
activity.RecordHeartbeat(ctx, info.Attempt*100)
time.Sleep(2 * info.HeartbeatTimeout)
// Currently we have a server bug which accepts completion from different attempt
// For now fail the activity
return 0, errRetryableActivityError
}

return progress, nil
Expand Down

0 comments on commit 8345cc7

Please sign in to comment.