Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look and Feel Update / Front Pages #228

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Look and Feel Update / Front Pages #228

merged 15 commits into from
Jan 24, 2024

Conversation

robmoffat
Copy link
Member

@robmoffat
Copy link
Member Author

See: https://deploy-preview-228--open-source-readiness.netlify.app/opensourcereadiness

And: https://deploy-preview-228--open-source-readiness.netlify.app/docs/bok/Introduction

And: https://deploy-preview-228--open-source-readiness.netlify.app/InnerSource

@robmoffat robmoffat requested review from mimiflynn and a team January 18, 2024 11:40
mimiflynn
mimiflynn suggested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@mimiflynn mimiflynn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing is what gets me, man.

docs/bok/Training/Introduction.md Show resolved Hide resolved
website/src/css/customTheme.css Outdated Show resolved Hide resolved
website/src/css/customTheme.css Outdated Show resolved Hide resolved
website/src/pages/InnerSource.js Show resolved Hide resolved
website/src/theme/BoxOut/styles.module.css Outdated Show resolved Hide resolved
website/static/img/bok/page-types/training.jpg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even sure I used this in the end? It's from chatgpt's dall-e plugin (straight out of the @psmulovics playbook!)

@robmoffat robmoffat requested a review from mimiflynn January 19, 2024 15:05
@robmoffat
Copy link
Member Author

@BrittanyIstenes and @chamindra please take a look - landing page added for InnerSource with placeholder text for now

mimiflynn
mimiflynn suggested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@mimiflynn mimiflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing.

website/src/theme/BoxOut/styles.module.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing isn't uniform in this one. If you're using VSCode you can do a 'format on save' and it should automatically fix spacing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, just pushed a commit. I'm using Eclipse for OSR, maybe I should change 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're up to give it a try, there is a configuration file that can be included in the root of the project that will automatically set VSCode preferences for the repository: https://github.com/mimiflynn/timer/blob/master/.vscode/settings.json

mimiflynn
mimiflynn approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@mimiflynn mimiflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@psmulovics psmulovics merged commit 0b270a6 into main Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimiflynn mimiflynn mimiflynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robmoffat @mimiflynn @psmulovics