Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Auth ChangeLog #645

Merged
merged 3 commits into from
Jan 11, 2018
Merged

Updates Auth ChangeLog #645

merged 3 commits into from
Jan 11, 2018

Conversation

protocol86
Copy link
Contributor

Updates the Auth ChangeLog for next release.

@protocol86 protocol86 requested a review from paulb777 January 11, 2018 02:03
paulb777
paulb777 requested changes Jan 11, 2018
View reviewed changes
Firebase/Auth/CHANGELOG.md Outdated
@@ -1,3 +1,8 @@
# v4.4.1
- Fixes bug where the FIRAuthResult object returned following a Phone Number authentication
always contained a nil FIRAdditionalUserInfo object. Now the FIRAdditionalUserInfo is never
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is never what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"nil", added.

Firebase/Auth/CHANGELOG.md Outdated
# v4.4.1
- Fixes bug where the FIRAuthResult object returned following a Phone Number authentication
always contained a nil FIRAdditionalUserInfo object. Now the FIRAdditionalUserInfo is never
and it's newUser field is populated correctly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"its" not "it's"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed.

@protocol86 protocol86 merged commit 7a600fc into master Jan 11, 2018
bstpierr added a commit that referenced this pull request Jan 12, 2018
@bstpierr
Merge branch 'master' into bstpierre-version-bump
978e9a3 
* master:
  Remove over-aggressive closeWithFinalState: delegate assert. (#656)
  Revert "Fully qualify protoc-generated outputs (#626)" (#653)
  Updates Auth ChangeLog (#645)
  Update CHANGELOG for Firestore v0.10.0 (#649)
  Fix FSTLocalDocumentsView to allow multiple mutations while offline (#644)
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@protocol86
Updates Auth ChangeLog (firebase#645)
24d3b31 
* Updates Auth ChangeLog

* addresses comments

* Fixes typo.
@paulb777 paulb777 deleted the changelog branch August 8, 2018 17:07
@firebase firebase locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@protocol86 @paulb777 @googlebot