Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fully qualify protoc-generated outputs (#626)" #653

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Revert "Fully qualify protoc-generated outputs (#626)" #653

merged 1 commit into from
Jan 11, 2018

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jan 11, 2018

This reverts commit bc74670.

#626 broke the import into google3 where the build doesn't use framework imports.

@wilhuff wilhuff requested a review from paulb777 January 11, 2018 22:43
@wilhuff
Copy link
Contributor Author

wilhuff commented Jan 11, 2018

Tested by hand

@wilhuff wilhuff merged commit 4acdbdb into master Jan 11, 2018
@wilhuff wilhuff deleted the wilhuff/proto-imports branch January 11, 2018 22:47
bstpierr added a commit that referenced this pull request Jan 12, 2018
@bstpierr
Merge branch 'master' into bstpierre-version-bump
978e9a3 
* master:
  Remove over-aggressive closeWithFinalState: delegate assert. (#656)
  Revert "Fully qualify protoc-generated outputs (#626)" (#653)
  Updates Auth ChangeLog (#645)
  Update CHANGELOG for Firestore v0.10.0 (#649)
  Fix FSTLocalDocumentsView to allow multiple mutations while offline (#644)
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@wilhuff
Revert "Fully qualify protoc-generated outputs (firebase#626)" (fireb…
dce7641 
…ase#653)

This reverts commit f2da0d4.
@firebase firebase locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees

@paulb777 paulb777

Labels
api: firestore cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilhuff @paulb777 @googlebot