Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/country-long-test-addition #16

Merged
merged 7 commits into from
Jun 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ steps:
commands: |
bash .buildkite/scripts/run_models.sh redshift

- label: ":bricks: Run Tests - Databricks"
- label: ":databricks: Run Tests - Databricks"
key: "run_dbt_databricks"
plugins:
- docker#v3.13.0:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# dbt_app_reporting v0.3.1
## Bug Fixes
[PR #16](https://github.com/fivetran/dbt_app_reporting/pull/16) includes the following bug fix.
- Included the `country_long` field in the unique combination of columns test for the `app_reporting__country_report`. It has been identified that Apple will sometimes provide records with different `country_long` names; however, they will be the same `country_short`. This is due to some countries having multiple `country_long` spelling variations.

# dbt_app_reporting v0.3.0

## Bug Fixes:
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'app_reporting'
version: '0.3.0'
version: '0.3.1'
config-version: 2
models:
app_reporting:
Expand Down
2 changes: 1 addition & 1 deletion docs/catalog.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manifest.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/run_results.json

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions integration_tests/ci/sample.profiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ integration_tests:
pass: "{{ env_var('CI_REDSHIFT_DBT_PASS') }}"
dbname: "{{ env_var('CI_REDSHIFT_DBT_DBNAME') }}"
port: 5439
schema: app_reporting_integrations_test_1
schema: app_reporting_integrations_test_2
threads: 8
bigquery:
type: bigquery
method: service-account-json
project: 'dbt-package-testing'
schema: app_reporting_integrations_test_1
schema: app_reporting_integrations_test_2
threads: 8
keyfile_json: "{{ env_var('GCLOUD_SERVICE_KEY') | as_native }}"
snowflake:
Expand All @@ -33,7 +33,7 @@ integration_tests:
role: "{{ env_var('CI_SNOWFLAKE_DBT_ROLE') }}"
database: "{{ env_var('CI_SNOWFLAKE_DBT_DATABASE') }}"
warehouse: "{{ env_var('CI_SNOWFLAKE_DBT_WAREHOUSE') }}"
schema: app_reporting_integrations_test_1
schema: app_reporting_integrations_test_2
threads: 8
postgres:
type: postgres
Expand All @@ -42,13 +42,13 @@ integration_tests:
pass: "{{ env_var('CI_POSTGRES_DBT_PASS') }}"
dbname: "{{ env_var('CI_POSTGRES_DBT_DBNAME') }}"
port: 5432
schema: app_reporting_integrations_test_1
schema: app_reporting_integrations_test_2
threads: 8
databricks:
catalog: null
host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
schema: app_reporting_integrations_test_1
threads: 2
schema: app_reporting_integrations_test_2
threads: 8
token: "{{ env_var('CI_DATABRICKS_DBT_TOKEN') }}"
type: databricks
6 changes: 3 additions & 3 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: 'app_reporting_integration_tests'
version: '0.3.0'
version: '0.3.1'
profile: 'integration_tests'
config-version: 2

vars:
google_play_schema: app_reporting_integrations_test_1
apple_store_schema: app_reporting_integrations_test_1
google_play_schema: app_reporting_integrations_test_2
apple_store_schema: app_reporting_integrations_test_2
google_play_source:
stats_installs_app_version_identifier: "stats_installs_app_version"
stats_crashes_app_version_identifier: "stats_crashes_app_version"
Expand Down
4 changes: 3 additions & 1 deletion integration_tests/seeds/app_store_territory_source_type.csv
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ app_id,date,source_type,territory,meets_threshold,impressions,_fivetran_synced,i
12345,2021-11-24 00:00:00+00:00,App Store Search,Kosovo,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
12345,2021-10-24 00:00:00+00:00,App Store Search,Côte d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
12345,2021-10-26 00:00:00+00:00,App Store Search,Cote d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
12345,2021-11-26 00:00:00+00:00,App Store Search,Cote d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
12345,2021-11-26 00:00:00+00:00,App Store Search,Cote d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
12345,2021-11-26 00:00:00+00:00,App Store Search,Turkey,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
12345,2021-11-26 00:00:00+00:00,App Store Search,Türkiye,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
1 change: 1 addition & 0 deletions models/app_reporting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ models:
- app_platform
- app_name
- country_short
- country_long
columns:
- name: date_day
description: '{{ doc("date_day") }}'
Expand Down