Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install cufinufft on windows #441

Open
Divisible8737 opened this issue May 8, 2024 · 8 comments
Open

pip install cufinufft on windows #441

Divisible8737 opened this issue May 8, 2024 · 8 comments
Assignees

Comments

@Divisible8737
Copy link

Is this supposed to work on windows?

From the latest stable version of Anaconda on Windows 11 I get

(base) PS C:\> pip install cufinufft
ERROR: Could not find a version that satisfies the requirement cufinufft (from versions: none)
ERROR: No matching distribution found for cufinufft
@lu1and10
Copy link
Member

lu1and10 commented May 8, 2024

I guess only linux wheels are uploaded, https://pypi.org/project/cufinufft/#files

@ahbarnett
Copy link
Collaborator

ahbarnett commented May 9, 2024 via email

@janden
Copy link
Collaborator

janden commented May 9, 2024

I'm not sure we've been able to get cuFinufft to build on those platforms, to be honest. I think Garrett looked into it back in the day, but I think we decided that trying to figure out the CUDA compilation steps under Windows would be quite a lot of work and we didn't have any Windows users at that point. macOS might be easier to reach. Things may be easier with cmake, since hopefully that would take care of a lot of the Windows stuff.

@turbotage
Copy link

@janden About a year ago or so, when I was on Windows (I'm on Linux now), I forked finufft and managed to build cufinufft on Windows. I also added some install steps so finufft could be better consumed in other CMake projects. I don't remember the tricks that finally made it build. But if you are interested, feel free to read my CMakeLists, CMakePresets, and so on here. I think one key thing was that static libs just doesn't work on windows with cuda.

The transition to cmake was great! But I still think some improvements in the build/install setup would be great! Like fixing build on Windows as a start, then adding install steps so finufft can be consumed via find_package(...) and target_link_libraries(...) in cmake. Then perhaps adding ports on popular package managers like vcpkg. This would make it so much nicer to consume and link against.

Perhaps this should be it's own issue :D

@DiamonDinoia
Copy link
Collaborator

DiamonDinoia commented Jul 22, 2024

I think this can be incorporated in #497 then it should be okay.

@janden
Copy link
Collaborator

janden commented Jul 22, 2024

I agree this is something we should look into. Currently, however, I'm not sure we have access to a Windows computer with a GPU that we can use to test things on.

@janden janden self-assigned this Jul 22, 2024
@DiamonDinoia
Copy link
Collaborator

I can test it, once you make it work on linux I can give it a go.

@janden
Copy link
Collaborator

janden commented Jul 23, 2024

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants