New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set default dy=None #20

Merged

lgarrison merged 1 commit into flatironinstitute:main from soichiro-hattori:dy

Jun 12, 2024

Contributor

soichiro-hattori commented Jun 12, 2024

Setting dy=None for core.lomb_scargle since otherwise it requires the user to manually set dy=None when calling the function.


          set default dy=None

550eb60

Member

lgarrison commented Jun 12, 2024

Oops, yes, it was clearly meant to have a default since the type hint is Optional[...]. Thanks!

lgarrison merged commit 1e5b7d4 into flatironinstitute:main

1 check passed

soichiro-hattori deleted the dy branch

June 12, 2024 18:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet