-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Updates to dropdown selected states #25635
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25635 +/- ##
=======================================
Coverage 63.58% 63.58%
=======================================
Files 1622 1622
Lines 155049 155052 +3
Branches 4055 4054 -1
=======================================
+ Hits 98590 98592 +2
- Misses 48690 48691 +1
Partials 7769 7769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
05a35c4
to
8306655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks in advance for bearing with me on explaining which colors go where. I was kinda able to follow the thread but...
boxShadow: "none", | ||
cursor: "pointer", | ||
"&:hover": { | ||
boxShadow: "none", | ||
".team-dropdown__single-value": { | ||
color: COLORS["core-vibrant-blue-over"], | ||
color: COLORS["core-fleet-blue"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I'm clear, ui-vibrant-blue-10
is for focused and ui-vibrant-blue-25
is for active (and no special treatment for selected)? And we want on-hover here in particular to be core-fleet-blue
(I'm guessing we already have that hover set elsewhere?), and foreground old-style dropdown elements to be $core-vibrant-blue-down
when activated? And I'm guessing none of these four colors are equivalent?
Sorry for basically requesting a quick rehash of the thread on this that I read earlier (don't have access to the associated Figma)...I'm pretty sure this is okay here, but want to understand what I'm looking at, and an answer here may be useful for QA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got access to Figma. Guessing the color I'm seeing in Figma is ui-vibrant-blue-10
, with ui-vibrant-blue-25
showing up for the split second a menu item is clocked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, yeah, I think I'm understanding things. An explanation of core-fleet-blue
and $core-vibrant-blue-down
would be helpful, but from what I can tell we're good to go here (after removing the unused import).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that colors are as expected for now, with an eng initiated issue filed to clean up color names.
Issue
For #25257
Description
Other code cleanup
APP_CONTEX_NO_TEAM_SUMMARY
any
with the proper typehelp-text
mixinborder-radius
mixin<Dropdown/>
using react-select 1.3.0 to<DropdownWrapper/>
using react-select 5.4.0 (in an ideal world I'd have time to convert all of them)Screenrecording of example fixes
Screen.Recording.2025-01-21.at.2.20.57.PM.mov
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.