-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fli-iam#1864] Add NIRS type BIDS #1865
Conversation
shanoir-ng-front/src/app/import/bids/bids-upload.component.html
Outdated
Show resolved
Hide resolved
shanoir-ng-datasets/src/main/java/org/shanoir/ng/dataset/security/DatasetSecurityService.java
Show resolved
Hide resolved
Hi, I think we could extend the import description to add NIRS [anat/func/dwi/eeg/ieeg/pet/..] on the web page to show, what modality we support. |
Hi, I think we might have to verify, if today's acquisition equipment fits to NIRS. So, when we create an unknown equipment, is it possible for somebody to enter the equipment info for NIRS OR do we risk to create unknown-unknown equipments? I know for MR, CT (not yet in BIDS) and PT we are fine, but I think there might be a gap with NIRS? |
@michaelkain added 'Nirs' as BIDS data type in study card |
Very good! Concering my comment on the equipment: I am right, that it remains empty for NIRS in the ds_acquisition? What is by the way totally fine for me. I just wanted to avoid dangling "unknown" equipments. |
Added manufacturer model modality type 'Nirs' |
It will remain empty if none are found. However we now can also create 'Nirs' equipment in Shanoir. |
Hi @michaelkain, Should be OK now ! |
Hi Youenn, thank you for your corrections. I downloaded one of the big NIRS examples above and did some tests, that showed some strange outputs:
|
more issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @youennmerel, please see my comments. Thank you!
Hi @michaelkain, I took your comments into account, except for (as discussed in daily) :
|
Hi @youennmerel, thank you! The 2 issues above are now fixed. I found two new ones, see my screenshots. I think with multiple sessions you just have to remove the trailing "-" from "ses-1-". I am wondering, as we have the acquisition time in the scans.tsv, if we could not use this as exam date, without time stamp maybe? |
Hi @youennmerel, I hope you had a good start into your day. For the <label>s, see BIDS spec: Full name: Subject Full name: Session |
Hi @michaelkain,
|
shanoir-ng-datasets/src/main/java/org/shanoir/ng/bids/service/BIDSServiceImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @youennmerel !!! Much better looking BIDS tree now, thank you!!!
NIRS BIDS files can now be imported into Shanoir
Specs : https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/11-near-infrared-spectroscopy.html
How to test :
Data samples :
https://osf.io/juxy8
https://github.com/bids-standard/bids-examples#nirs-datasets