Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation: switch to YAML config files by default #1551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Jan 15, 2025

See fluent/fluent-bit#9837, update to use YAML config by default.

I have not tackled providing YAML config for all installation options in the docs, this is mostly to cover the upgrade impact. Ideally @fluent/chronosphere-tech-writers we can also update all the legacy config in the docs to also have a YAML config example by default.

Copy link
Member

@alexakreizinger alexakreizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a few suggestions for clarity—although let me know if I misunderstood anything and made suggestions that don't make sense 😅

@@ -9,6 +9,15 @@ Note: release notes will be prepared in advance of a Git tag for a release so an
The tag drives the overall binary release process so release binaries (containers/packages) will appear after a tag and its associated release note.
This allows users to expect the new release binary to appear and allow/deny/update it as appropriate in their infrastructure.

## Fluent Bit v4.0+

The default configuration file has been switched to use YAML format and a different name (`.yaml` file suffix instead of `.conf`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default configuration file has been switched to use YAML format and a different name (`.yaml` file suffix instead of `.conf`).
By default, configuration files use YAML syntax and the `.yaml` file extension.


The default configuration file has been switched to use YAML format and a different name (`.yaml` file suffix instead of `.conf`).

This may require updating any custom deployments to either provide a YAML configuration or switch back to using legacy configuration in the arguments to the Fluent Bit binary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This may require updating any custom deployments to either provide a YAML configuration or switch back to using legacy configuration in the arguments to the Fluent Bit binary.
You may need to update your custom deployments to either use YAML configuration files
or switch back to using legacy configuration in the arguments to the Fluent Bit binary.

Comment on lines +18 to +19
For Linux the Systemd unit will need overriding to specify `-c <legacy config file>`.
Similarly for containers, Windows and macOS the default launch command is changed to point at the YAML config file by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For Linux the Systemd unit will need overriding to specify `-c <legacy config file>`.
Similarly for containers, Windows and macOS the default launch command is changed to point at the YAML config file by default.
In Linux environments, you must override the systemd unit to specify `-c <legacy config file>`.
Similarly, in Windows and macOS container environments, the default launch command uses YAML configuration files
by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants