-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: switch to YAML config files by default #9837
base: master
Are you sure you want to change the base?
Conversation
d44a034
to
1452694
Compare
1452694
to
a5dc8fc
Compare
Signed-off-by: Patrick Stephens <[email protected]>
a5dc8fc
to
156fc0a
Compare
cc @stevehipwell on the helm side - the current chart uses a legacy config by default so should not be impacted by this change but maybe we should change the defaults there too? |
@patrick-stephens is the YAML support now idiomatic? I saw |
There's no change to syntax here, this is primarily around the default config file we're using. |
So in the context of Kubernetes I think the current "YAML" format is problematic given the fact that it's not idiomatic YAML but is called YAML and looks like YAML. That said am I correct in understanding that some capabilities are only available via the YAML config? |
Resolves #9714 by switching to using YAML configuration by default for all packages and containers.
For containers we should prepare a PR for the helm chart as well but it will not break the helm chart as that explicitly uses a
.conf
file for now.We should ensure this is properly notified during the release notes and beforehand for folks to do any required updates to their rollouts.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
installation: switch to YAML config files by default fluent-bit-docs#1551
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.