This repository has been archived by the owner on May 17, 2019. It is now read-only.
add http_x_forwarded_for to nginx parsed fields #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujimotos
suggested changes
Apr 23, 2018
docs/v1.0/parser_nginx.txt
Outdated
| time_format %d/%b/%Y:%H:%M:%S %z | ||
|
|
||
| `remote`, `user`, `method`, `path`, `code`, `size`, `referer` and `agent` are included in the event record. `time` is used for the event time. | ||
| `remote`, `user`, `method`, `path`, `code`, `size`, `referer`, 'agent' and `http_x_forwarded_for` are included in the event record. `time` is used for the event time. |
There was a problem hiding this comment.
I noticed that you mixes backticks and quotes in this line.
Could you update this line to use backticks properly?
|
@yaron-idan I'd like to merge this commit after Fluentd v1.2.0 has been released. So could you 1) sign off your commit to certify the origin (using |
|
No problem, I'll add the fix. I'm also gonna close this PR and open a new with the signed commits as I've yet to understand how/whether it's possible to sign already unsigned commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referencing fluent/fluentd#1912