added http-x-forwarded-for field to nginx parser #1912
Conversation
test/plugin/test_parser_nginx.rb
Outdated
| @@ -24,23 +25,23 @@ def create_driver | |||
|
|
|||
| def test_parse | |||
| d = create_driver | |||
| d.instance.parse('127.0.0.1 192.168.0.1 - [28/Feb/2013:12:00:00 +0900] "GET / HTTP/1.1" 200 777 "-" "Opera/12.0"') { |time, record| | |||
| d.instance.parse('127.0.0.1 192.168.0.1 - [28/Feb/2013:12:00:00 +0900] "GET / HTTP/1.1" 200 777 "-" "Opera/12.0" -') { |time, record| | |||
There was a problem hiding this comment.
Don't change existing test because it is needed to check compatibility.
There was a problem hiding this comment.
I see, this test will fail though if it won't be adapted to the nginx log format, how are you suggesting to overcome this issue? Create another test with the new format?
There was a problem hiding this comment.
Create another test
Yes, creating new test is needed. Many users use nginx format so we can't break it. changing behaviour breaks user environment and causes log lost.
the new format?
One regular expression seems to support both with/without http_x_forwarded_for logs.
|
I've fixed the REGEXP to make the new field optional. I've also heed the advice of an SO answer and swapped |
|
|
Signed-off-by: yaron-idan <[email protected]>
|
OK, seems I'm gonna have to open a new PR since DCO rejects commits without a sign off, I'm gonna close this one and open a new one with the changes requested + a sign off. |
Closing #1907, an update to the docs has been proposed in fluent/fluentd-docs#471.