Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable metadata auto-sync for ThinRuntime by default #4281

Conversation

TrafalgarZZZ
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ commented Aug 20, 2024

Ⅰ. Describe what this PR does

Code changes in this PR:

  • disable metadata auto-sync for ThinRuntime by default
  • update crd to remove // +kubebuilder:default=true for spec.management.metadataSyncPolicy.autoSync.
    • NOTE: The removal is backward compatible because we take an empty metadataSyncPolicy.autoSync as truew before.
func (msb *MetadataSyncPolicy) AutoSyncEnabled() bool {
	return msb.AutoSync == nil || *msb.AutoSync
}

Ⅱ. Does this pull request fix one issue?

fixes #4282

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Related to #4091 where we allow users to disable metadata auto-sync, while this PR make it a default behavior.

Copy link

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.94%. Comparing base (90340fc) to head (998feda).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4281      +/-   ##
==========================================
- Coverage   63.20%   62.94%   -0.27%     
==========================================
  Files         482      482              
  Lines       28532    28542      +10     
==========================================
- Hits        18035    17966      -69     
- Misses       8292     8372      +80     
+ Partials     2205     2204       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TrafalgarZZZ
Copy link
Member Author

/test fluid-e2e

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@TrafalgarZZZ
Copy link
Member Author

/override codecov/project

Copy link

fluid-e2e-bot bot commented Aug 21, 2024

@TrafalgarZZZ: cannot create prow-override CheckRun {0 998feda completed success {Prow override - codecov/project Prow has received override command for the codecov/project checkrun. 0 [] []} codecov/project {0 [] } {0 { 0 {false false false false false} } []} []}

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TrafalgarZZZ
Copy link
Member Author

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Aug 21, 2024

@TrafalgarZZZ: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

fluid-e2e-bot bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang, TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TrafalgarZZZ,cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 7ef9efd into fluid-cloudnative:master Aug 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURES] Disable metadata auto-sync for ThinRuntime by default
2 participants