-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable metadata auto-sync for ThinRuntime by default #4281
disable metadata auto-sync for ThinRuntime by default #4281
Conversation
Signed-off-by: trafalgarzzz <[email protected]>
Signed-off-by: trafalgarzzz <[email protected]>
Signed-off-by: trafalgarzzz <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
- Coverage 63.20% 62.94% -0.27%
==========================================
Files 482 482
Lines 28532 28542 +10
==========================================
- Hits 18035 17966 -69
- Misses 8292 8372 +80
+ Partials 2205 2204 -1 ☔ View full report in Codecov by Sentry. |
/test fluid-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/override codecov/project |
@TrafalgarZZZ: cannot create prow-override CheckRun {0 998feda completed success {Prow override - codecov/project Prow has received override command for the codecov/project checkrun. 0 [] []} codecov/project {0 [] } {0 { 0 {false false false false false} } []} []} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@TrafalgarZZZ: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang, TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7ef9efd
into
fluid-cloudnative:master
Ⅰ. Describe what this PR does
Code changes in this PR:
// +kubebuilder:default=true
forspec.management.metadataSyncPolicy.autoSync
.metadataSyncPolicy.autoSync
astrue
w before.Ⅱ. Does this pull request fix one issue?
fixes #4282
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Related to #4091 where we allow users to disable metadata auto-sync, while this PR make it a default behavior.