Buildroot side of change to narrow Windows Android arm hack #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
approved these changes
Nov 1, 2022
zanderso
force-pushed
the
fix-win-hack
branch
from
37f0ef8 to
f33db0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the buildroot side of flutter/engine#37125, which will narrow the hack we use to build
gen_snapshotto target 32-bit Android on Windows. In particular, along with 37125, this patch adjusts so thatcurrent_cpuandhost_cpuwill always be the host architecture (x86), andtarget_cpu, anddart_target_archwill be the target architecture (arm). This confusing state will only exist for this one configuration following these patches.