This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Narrow the scope of the Windows Android arm hack #37125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2022
zanderso
changed the title
|
Presubmits are angry at the python script formatting. I'll fix it before landing. |
godofredoc
reviewed
Nov 1, 2022
godofredoc
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
LGTM after updating the DEPS file with flutter/buildroot#645
cbracken
reviewed
Nov 1, 2022
cbracken
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
LGTM modulo switching back to flutter/buildroot from zanderso/buildroot as noted by @godofredoc.
zanderso
force-pushed
the
fix-win-hack
branch
from
f86b487 to
f8f338b
Compare
zanderso
force-pushed
the
fix-win-hack
branch
from
f8f338b to
a5e7032
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2022
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Nov 5, 2022
…lutter/engine#37125) (#114751) Commit: 07d3a64b5d01fe1c09254f9ac9d0ac1cb2aec736
This was referenced Nov 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 6, 2022
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Nov 6, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390) * 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751) * cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694) * 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703) * b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759) * b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760) * 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
8 tasks
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 7, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390) * 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751) * cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694) * 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703) * b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759) * b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760) * 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390) * 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751) * cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694) * 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703) * b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759) * b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760) * 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
percula
pushed a commit
to percula/packages
that referenced
this pull request
Nov 17, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390) * 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751) * cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694) * 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703) * b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759) * b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760) * 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390) * 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751) * cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694) * 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703) * b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759) * b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760) * 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* cef4c2a ICU Message Syntax Parser (flutter/flutter#112390) * 07d3a64 0886c7d0b Narrow the scope of the Windows Android arm hack (flutter/engine#37125) (flutter/flutter#114751) * cf0cd06 Mark new_gallery__transition_perf as non-flaky (flutter/flutter#114694) * 5bc50c1 Fix macOS migration nothing-to-upgrade test (flutter/flutter#114703) * b1509ed 36cfa9e68 Apply the Windows friendly path solution in remaining spots (flutter/engine#37344) (flutter/flutter#114759) * b45e628 b8218eacc Roll Fuchsia Mac SDK from Ua8Jtf8Zka9uxIVdl... to sNXsQVxntMX8f42LE... (flutter/engine#37352) (flutter/flutter#114760) * 5ea5a53 6f3018a72 Roll Skia from a34882309d04 to c3c31be8729b (1 revision) (flutter/engine#37358) (flutter/flutter#114765)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine side of flutter/buildroot#645