Fix .ci.yaml validation for Fusion (the monorepo)
#4137
Conversation
| exceptions.add('ERROR: ${target.name} is missing `.ci.yaml` in runIf'); | ||
| } | ||
|
|
||
| // 2. The engine repo must additionally depend on DEPS. |
There was a problem hiding this comment.
Can you please leave a TODO with a link to an issue reminding us to clean this up once we're ready to archive the engine repo?
There was a problem hiding this comment.
Filed as flutter/flutter#160874
| final ciYamlPath = switch (type) { | ||
| CiType.fusionEngine => 'engine/src/flutter/.ci.yaml', | ||
| _ => '.ci.yaml', | ||
| }; |
There was a problem hiding this comment.
Can these be added automatically by the .ci.yaml parser (or by the logic that evaluates runIf conditions)? This way we don't have to specify anything in the yaml files. Seems like they add a bunch of noise. Totally fine we want to take this one step at a time though.
There was a problem hiding this comment.
Filed as flutter/flutter#160874
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/cocoon/4137, due to - The status or check suite Linux Cocoon has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
Few entries were missed in #160706 and caused [failures](https://github.com/flutter/flutter/pull/160191/checks?check_run_id=34920131317) when [this](flutter/cocoon#4137) landed.
Few entries were missed in #160706 and caused [failures](https://github.com/flutter/flutter/pull/160191/checks?check_run_id=34920131317) when [this](flutter/cocoon#4137) landed.
Towards #160915 (future cleanup: remove the validation from `flutter/cocoon`). This PR effectively duplicates the logic in flutter/cocoon#4137, in `flutter/flutter`. /cc @jtmcdole
…61249) Towards flutter#160915 (future cleanup: remove the validation from `flutter/cocoon`). This PR effectively duplicates the logic in flutter/cocoon#4137, in `flutter/flutter`. /cc @jtmcdole
Closes flutter/flutter#160707.
Fixes a bug where
DEPSwas accidentally (or purposefully, there were no tests to verify) not checked for framework builds, and then expands on the validation by adding a check forengine/**for framework builds, adding a check nobody usesrunIfNot, which is extremely broken and should not be used, and then lastly refactors the code and adds tests for the next shmuck to want to change this.