Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DEPS to runIf #160913

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Add missing DEPS to runIf #160913

merged 5 commits into from
Dec 27, 2024

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 27, 2024

Few entries were missed in #160706 and caused failures when this landed.

@mdebbar mdebbar changed the base branch from main to master December 27, 2024 18:18
@matanlurey matanlurey added the warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Dec 27, 2024
@matanlurey matanlurey enabled auto-merge December 27, 2024 18:18
@matanlurey matanlurey added this pull request to the merge queue Dec 27, 2024
@mdebbar mdebbar removed this pull request from the merge queue due to a manual request Dec 27, 2024
@mdebbar mdebbar added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Dec 27, 2024
@mdebbar mdebbar added this pull request to the merge queue Dec 27, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #160913 at sha 51d6f32

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Dec 27, 2024
Merged via the queue into master with commit 7a50802 Dec 27, 2024
180 of 181 checks passed
@mdebbar mdebbar deleted the mdebbar-patch-1 branch December 27, 2024 20:14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergency Jump the queue; land PR in front of all others; only use for emergencies warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. will affect goldens Changes to golden files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants