Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools License and 3P Notice Review #8216

Open
4 of 5 tasks
mossmana opened this issue Aug 20, 2024 · 0 comments
Open
4 of 5 tasks

DevTools License and 3P Notice Review #8216

mossmana opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
audit P1 high priority issues at the top of the work list, actively being worked on.

Comments

@mossmana
Copy link
Contributor

mossmana commented Aug 20, 2024

  • Conduct a review of all code in DevTools and determine where licenses need to be added/updated and/or require a 3P notice for dependencies.
  • Write a utility that can test for missing/incorrect licenses and add/update the licenses where necessary.

// Copyright 2019 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

  • Update DevTools tool to execute the utility from the command line. (NOTE: This will only be available from the forked branch unless there is enough interest to merge into the main repo.)
  • Run the DevTools tool command against the repository files.
  • DevTools should also show notices in an about dialog or help menu option.

e.g. Here's what the help menu option looks like in VS Code (just a link that redirects to https://code.visualstudio.com/license?lang=en)
Screenshot 2024-08-20 at 9 12 11 AM

@mossmana mossmana self-assigned this Aug 20, 2024
@mossmana mossmana added d: devtools P1 high priority issues at the top of the work list, actively being worked on. labels Aug 20, 2024
@mossmana mossmana mentioned this issue Oct 21, 2024
7 tasks
mossmana added a commit that referenced this issue Nov 7, 2024
Created a utility for updating licenses in configured source files that can be run via tests and/or standalone.
#8216

* Initial YAML config parsing logic and tests

* added additional YAML config parsing logic

* Added comments and some logic to parse stored value

* renamed functions to better match functionality, added logic to return replacement header, and added more tests

* added support for bulk update

* added test for full repo check for incorrect licenses

* ran dart formatter

* fixed missing training commas

* moved license utils to tool

* fixed dependencies

* added github action to run tool tests

* added write permission to tool_tests.sh

* fixed Dartdoc function comment, experimenting with repo wide check test on CI

* excluding flutter-sdk dependencies from repo wide check

* test that the repo wide check actually catches incorrect license header

* Turned off repo wide check test

* addressed PR feedback

* addressed more PR feedback

* reverted some accidentally changed files, addressed additional PR feedback

* fixed DartDoc and other PR feedback

* added dry run option for bulk update

* corrected logic for test

* fixed missing trailing comma

* addressing some missed PR feedback

* removed late and added back final to member variables

* added clearer docs and removed unnecessary todo

* addressed missed PR feedback

* addressed another round of PR feedback

* fixed git issues

* additional PR feedback

* another round of PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit P1 high priority issues at the top of the work list, actively being worked on.
Projects
None yet
Development

No branches or pull requests

2 participants