Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License update - Batch 60 #8775

Merged
merged 2 commits into from
Jan 17, 2025
Merged

License update - Batch 60 #8775

merged 2 commits into from
Jan 17, 2025

Conversation

mossmana
Copy link
Contributor

Updates the license headers for:

  1. packages/devtools_shared/lib/devtools_extensions.dart
  2. packages/devtools_shared/lib/devtools_extensions_io.dart
  3. packages/devtools_shared/lib/src/extensions/constants.dart
  4. packages/devtools_shared/lib/src/extensions/extension_enablement.dart
  5. packages/devtools_shared/lib/src/extensions/extension_manager.dart
  6. packages/devtools_shared/lib/src/extensions/extension_model.dart
  7. packages/devtools_shared/lib/src/extensions/yaml_utils.dart
  8. packages/devtools_shared/test/extensions/extension_enablement_test.dart
  9. packages/devtools_shared/test/extensions/extension_model_test.dart
  10. packages/devtools_shared/test/helpers/extension_test_manager.dart
  11. packages/devtools_shared/test/helpers/extension_test_manager_test.dart

#8216

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

mossmana
mossmana commented Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/extensions/constants.dart Outdated
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
Copy link
Contributor Author

@mossmana mossmana Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly copied from Dart SDK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file was copied. It is possible the header was mistakenly copied from another file that had the Dart project authors header instead of the Chromium header.

mossmana
mossmana commented Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/extensions/extension_enablement.dart Outdated
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
Copy link
Contributor Author

@mossmana mossmana Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly copied from Dart SDK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. This file was not copied from the Dart SDK. Probably just a bad header.

mossmana
mossmana commented Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/extensions/extension_manager.dart Outdated
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
Copy link
Contributor Author

@mossmana mossmana Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly copied from Dart SDK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment.

mossmana
mossmana commented Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/extensions/yaml_utils.dart Outdated
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
Copy link
Contributor Author

@mossmana mossmana Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly copied from Dart SDK

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment. Since all these files are near each other it was probably a case of copying the wrong header as a base header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll manually correct. Thanks!

kenzieschmoll
kenzieschmoll reviewed Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/extensions/constants.dart
@@ -1,3 +1,6 @@
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove double header

@mossmana mossmana marked this pull request as ready for review January 17, 2025 19:52
@mossmana mossmana requested a review from bkonyi as a code owner January 17, 2025 19:52
@mossmana mossmana merged commit 9551da1 into flutter:master Jan 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmana @kenzieschmoll