Add service manager tests and test_driver. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
jacob314
reviewed
Dec 18, 2018
|
Lgtm
…On Wed, Dec 19, 2018, 8:18 AM Kenzie Schmoll ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In test/service_manager_test.dart
<#60 (comment)>:
> + stream.cancel();
+ });
+
+ // Enable the service extension via ServiceExtensionManager.
+ await serviceManager.serviceExtensionManager
+ .setServiceExtensionState('ext.flutter.debugPaint', true, true);
+
+ // Verify the test device is aware of the newly-enabled state.
+ final after = await library.eval('debugPaintSizeEnabled', isAlive: null);
+ if (after is InstanceRef) {
+ expect(after.valueAsString, 'true');
+ }
+ // Verify ServiceExtensionManager is aware of the newly-enabled state.
+ stream = serviceManager.serviceExtensionManager
+ .getServiceExtensionState('ext.flutter.debugPaint', null);
+ stream.onData((ServiceExtensionState state) {
see above. Obsolete now.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#60 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABK4PJuAScWvDLgwvyLRRfvDqa4EsGjjks5u6mbugaJpZM4ZZQ2A>
.
|
jacob314
reviewed
Dec 21, 2018
jacob314
reviewed
Dec 21, 2018
jacob314
reviewed
Dec 27, 2018
jacob314
reviewed
Dec 27, 2018
jacob314
reviewed
Dec 27, 2018
jacob314
approved these changes
Dec 27, 2018
jacob314
reviewed
Dec 27, 2018
jacob314
reviewed
Dec 27, 2018
jacob314
reviewed
Dec 27, 2018
jacob314
approved these changes
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some async/await polish as well.