Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enterkeyhint property to web textfields #35411

Merged
merged 3 commits into from
Aug 31, 2022
Merged

add enterkeyhint property to web textfields #35411

merged 3 commits into from
Aug 31, 2022

Conversation

TimWhiting
Copy link
Contributor

@TimWhiting TimWhiting commented Aug 15, 2022 •
edited by mdebbar
Loading

Adds the enterkeyhint property to web textfields
@mdebbar Can you take a look at this?

List which issues are fixed by this PR. You must list at least one issue.
Fixes: flutter/flutter#100708
Fixes: flutter/flutter#73835

Here is the screenshot of the input action button being displayed properly.
fixed

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Aug 15, 2022
@TimWhiting TimWhiting marked this pull request as draft August 15, 2022 20:26
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@TimWhiting TimWhiting marked this pull request as ready for review August 15, 2022 20:50
@TimWhiting TimWhiting force-pushed the add_enterkeyhint_web branch from d23ac3f to c97737d Compare August 23, 2022 17:53
@mdebbar mdebbar self-requested a review August 24, 2022 19:22
mdebbar
mdebbar requested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also want to add an entry for the new file (input_action.dart) here:

engine/ci/licenses_golden/licenses_flutter

Lines 1278 to 1282 in ab35696

FILE: ../../../flutter/lib/web_ui/lib/src/engine/text_editing/autofill_hint.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/text_editing/composition_aware_mixin.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/text_editing/input_type.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/text_editing/text_capitalization.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart

lib/web_ui/lib/src/engine/text_editing/input_action.dart Outdated Show resolved Hide resolved
lib/web_ui/lib/src/engine/text_editing/input_action.dart Outdated Show resolved Hide resolved
@TimWhiting
Copy link
Contributor Author

Thanks @mdebbar, this was my first time contributing to flutter itself (I've contributed to the plugins), so I was really confused with the license issue.

@mdebbar mdebbar self-requested a review August 26, 2022 14:15
mdebbar
mdebbar approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution to the web engine!

@TimWhiting
Copy link
Contributor Author

Is there some tag to auto merge this or does someone have to manually merge it?

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2022

Validations Fail.

@TimWhiting
Copy link
Contributor Author

TimWhiting commented Aug 29, 2022 •
edited
Loading

@mdebbar who would be another good reviewer for this? It looks like I need an additional review?

@mdebbar
Copy link
Contributor

mdebbar commented Aug 29, 2022

@TimWhiting I'll try and get a review from another team member.

@mdebbar
Copy link
Contributor

mdebbar commented Aug 31, 2022

@TimWhiting does this PR fix flutter/flutter#73835 too?

@TimWhiting
Copy link
Contributor Author

@TimWhiting does this PR fix flutter/flutter#73835 too?

Yes, I think so

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2022
@auto-submit auto-submit bot merged commit f69e0cc into flutter:main Aug 31, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
f69e0ccc3 add enterkeyhint property to web textfields (flutter/engine…
493f9e2 
…#35411)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
f69e0ccc3 add enterkeyhint property to web textfields (flutter/engine…
a9f42d9 
…#35411)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
f69e0ccc3 add enterkeyhint property to web textfields (flutter/engine…
3172eec 
…#35411)
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 0ef08a85252a to d993e0d55fc6 (34 revisions) (#…
b94e48d 
…110697)

* d782c3303 [web] roll CanvasKit to 0.36.1 (flutter/engine#35747)

* 300592bc8 allows mallocmapping copies of size zero (flutter/engine#35803)

* 61e4c0715 Generate mac os framework with a global generator. (flutter/engine#35673)

* 7a03a54a8 Roll Skia from 545e45ab4d5d to 27a2eeacd330 (11 revisions) (flutter/engine#35805)

* 89909d966 Fix DartPerformanceMode enum mismatch (flutter/engine#35806)

* ead134880 Queue all semantic nodes & actions before completing batch (flutter/engine#35792)

* adec6edb0 Run clang-tidy and Mac Unopt on Xcode beta (flutter/engine#35793)

* eb6e2e08c Roll Skia from 27a2eeacd330 to 18b36bd2e2a3 (1 revision) (flutter/engine#35807)

* e74352c7f Remove extract_far.dart (flutter/engine#35801)

* 5ee7b3816 Test cover 'toImage'. (flutter/engine#35791)

* 8ed1e6ca7 Roll Skia from 18b36bd2e2a3 to 7c67a21eec59 (3 revisions) (flutter/engine#35810)

* cc2a32332 Roll Dart SDK from 9faec45da06c to 7e5a69f6b25f (1 revision) (flutter/engine#35811)

* c2a2a5679 Roll Fuchsia Linux SDK from NwG1XTWHxB9R3XcU5... to usGLIrlCJW1C1yaF1... (flutter/engine#35812)

* 8ab3b8f5a Migrate testing/symbols to null safety (flutter/engine#35809)

* 7e27b923b Roll Skia from 7c67a21eec59 to 3abad1ab16cc (1 revision) (flutter/engine#35816)

* 4cb5be089 [web] remove references to IE11 and old Edge; treat Samsung browser as Blink (flutter/engine#35205)

* 5154b8ac0 Roll Fuchsia Mac SDK from 4GZkuoQmvVanO84uA... to V_dBCcwGfOqJkrG9b... (flutter/engine#35817)

* b5a5a0dc7 Roll Dart SDK from 7e5a69f6b25f to 5a2737b71877 (1 revision) (flutter/engine#35818)

* e11457362 [dart:ui] Adds a reusable FragmentShader (flutter/engine#35253)

* 26d6bcfd6 Roll Skia from 3abad1ab16cc to a7829f6da292 (1 revision) (flutter/engine#35819)

* 6c9f6f5b8 Roll Skia from a7829f6da292 to 83b5d7ae4bca (2 revisions) (flutter/engine#35821)

* 169181f8d Make shader mask layer code builder aware (flutter/engine#35622)

* 06925ed06 Roll Fuchsia Linux SDK from usGLIrlCJW1C1yaF1... to 5YEIlndU4ncjOl9I_... (flutter/engine#35824)

* 7a40a0a26 Roll Skia from 83b5d7ae4bca to e4a2061eb1fc (1 revision) (flutter/engine#35826)

* 43ee40e31 Engine startup event timed after VM initializes (flutter/engine#35713)

* 9eb524bad Roll Fuchsia Mac SDK from V_dBCcwGfOqJkrG9b... to sgXD5SyRPOxGjWV4q... (flutter/engine#35829)

* cfdc83ad6 Roll Skia from e4a2061eb1fc to 34df0f94c849 (1 revision) (flutter/engine#35828)

* 90d65fa5f fix null access for CkParagraph.dispose (flutter/engine#35815)

* ef039c197 Update the API check script for the latest Dart analyzer APIs (flutter/engine#35831)

* c3c872776 Revert "[web] roll CanvasKit to 0.36.1 (#35747)" (flutter/engine#35837)

* db97b55d0 Roll Skia from 34df0f94c849 to e0b87738eca7 (5 revisions) (flutter/engine#35832)

* f69e0ccc3 add enterkeyhint property to web textfields (flutter/engine#35411)

* 54a1b59c9 Add a comment in the scenario app to meet the latest analyzer requirements (flutter/engine#35838)

* d993e0d55 Revert "[dart:ui] Adds a reusable FragmentShader (#35253)" (flutter/engine#35843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On-web keyboard incorrectly rendering action button TextInputAction.next on flutter web doesn't work.
3 participants
@TimWhiting @mdebbar @yjbanov