Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate mac os framework with a global generator. #35673

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Generate mac os framework with a global generator. #35673

merged 2 commits into from
Aug 30, 2022

Conversation

godofredoc
Copy link
Contributor

Previously we were generating mac os framework in the host_debug
subbuild but that was only updating the x64 architecture but the
expection is to include x64 and arm64. As those builds are generated
separately we need to create the FAT binaries in the orchestrator rather
than the subbuilds.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested a review from XilaiZhang August 24, 2022 16:40
@XilaiZhang
Copy link
Contributor

looks like its failing on not findingbuilder/src/out/android_release_arm64/clang_x64/analyze_snapshot, maybe sir Godofredo would interpret more out of this error message

@XilaiZhang XilaiZhang mentioned this pull request Aug 25, 2022
Merged
@XilaiZhang
Copy link
Contributor

umm Looks like the symlinks get dropped in the zip

@godofredoc
Generate mac os framework with a global generator.
e7fdcf1 
Previously we were generating mac os framework in the host_debug
subbuild but that was only updating the x64 architecture but the
expection is to include x64 and arm64. As those builds are generated
separately we need to create the FAT binaries in the orchestrator rather
than the subbuilds.
@godofredoc
Add --zip option to package the artifacts.
f1be1f5
@godofredoc
Copy link
Contributor Author

looks like its failing on not findingbuilder/src/out/android_release_arm64/clang_x64/analyze_snapshot, maybe sir Godofredo would interpret more out of this error message

Rebased the PR to include the new artifacts.

@godofredoc
Copy link
Contributor Author

umm Looks like the symlinks get dropped in the zip

Yes, this will be fixed at the CAS service level.

XilaiZhang
XilaiZhang approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
images (1)

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2022
@auto-submit auto-submit bot merged commit 61e4c07 into flutter:main Aug 30, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
61e4c0715 Generate mac os framework with a global generator. (flutter…
ff263eb 
…/engine#35673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
61e4c0715 Generate mac os framework with a global generator. (flutter…
fcbdada 
…/engine#35673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
61e4c0715 Generate mac os framework with a global generator. (flutter…
936238b 
…/engine#35673)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
61e4c0715 Generate mac os framework with a global generator. (flutter…
0fd1df0 
…/engine#35673)
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 0ef08a85252a to d993e0d55fc6 (34 revisions) (#…
b94e48d 
…110697)

* d782c3303 [web] roll CanvasKit to 0.36.1 (flutter/engine#35747)

* 300592bc8 allows mallocmapping copies of size zero (flutter/engine#35803)

* 61e4c0715 Generate mac os framework with a global generator. (flutter/engine#35673)

* 7a03a54a8 Roll Skia from 545e45ab4d5d to 27a2eeacd330 (11 revisions) (flutter/engine#35805)

* 89909d966 Fix DartPerformanceMode enum mismatch (flutter/engine#35806)

* ead134880 Queue all semantic nodes & actions before completing batch (flutter/engine#35792)

* adec6edb0 Run clang-tidy and Mac Unopt on Xcode beta (flutter/engine#35793)

* eb6e2e08c Roll Skia from 27a2eeacd330 to 18b36bd2e2a3 (1 revision) (flutter/engine#35807)

* e74352c7f Remove extract_far.dart (flutter/engine#35801)

* 5ee7b3816 Test cover 'toImage'. (flutter/engine#35791)

* 8ed1e6ca7 Roll Skia from 18b36bd2e2a3 to 7c67a21eec59 (3 revisions) (flutter/engine#35810)

* cc2a32332 Roll Dart SDK from 9faec45da06c to 7e5a69f6b25f (1 revision) (flutter/engine#35811)

* c2a2a5679 Roll Fuchsia Linux SDK from NwG1XTWHxB9R3XcU5... to usGLIrlCJW1C1yaF1... (flutter/engine#35812)

* 8ab3b8f5a Migrate testing/symbols to null safety (flutter/engine#35809)

* 7e27b923b Roll Skia from 7c67a21eec59 to 3abad1ab16cc (1 revision) (flutter/engine#35816)

* 4cb5be089 [web] remove references to IE11 and old Edge; treat Samsung browser as Blink (flutter/engine#35205)

* 5154b8ac0 Roll Fuchsia Mac SDK from 4GZkuoQmvVanO84uA... to V_dBCcwGfOqJkrG9b... (flutter/engine#35817)

* b5a5a0dc7 Roll Dart SDK from 7e5a69f6b25f to 5a2737b71877 (1 revision) (flutter/engine#35818)

* e11457362 [dart:ui] Adds a reusable FragmentShader (flutter/engine#35253)

* 26d6bcfd6 Roll Skia from 3abad1ab16cc to a7829f6da292 (1 revision) (flutter/engine#35819)

* 6c9f6f5b8 Roll Skia from a7829f6da292 to 83b5d7ae4bca (2 revisions) (flutter/engine#35821)

* 169181f8d Make shader mask layer code builder aware (flutter/engine#35622)

* 06925ed06 Roll Fuchsia Linux SDK from usGLIrlCJW1C1yaF1... to 5YEIlndU4ncjOl9I_... (flutter/engine#35824)

* 7a40a0a26 Roll Skia from 83b5d7ae4bca to e4a2061eb1fc (1 revision) (flutter/engine#35826)

* 43ee40e31 Engine startup event timed after VM initializes (flutter/engine#35713)

* 9eb524bad Roll Fuchsia Mac SDK from V_dBCcwGfOqJkrG9b... to sgXD5SyRPOxGjWV4q... (flutter/engine#35829)

* cfdc83ad6 Roll Skia from e4a2061eb1fc to 34df0f94c849 (1 revision) (flutter/engine#35828)

* 90d65fa5f fix null access for CkParagraph.dispose (flutter/engine#35815)

* ef039c197 Update the API check script for the latest Dart analyzer APIs (flutter/engine#35831)

* c3c872776 Revert "[web] roll CanvasKit to 0.36.1 (#35747)" (flutter/engine#35837)

* db97b55d0 Roll Skia from 34df0f94c849 to e0b87738eca7 (5 revisions) (flutter/engine#35832)

* f69e0ccc3 add enterkeyhint property to web textfields (flutter/engine#35411)

* 54a1b59c9 Add a comment in the scenario app to meet the latest analyzer requirements (flutter/engine#35838)

* d993e0d55 Revert "[dart:ui] Adds a reusable FragmentShader (#35253)" (flutter/engine#35843)
@godofredoc godofredoc deleted the generate_framework_global_generator branch January 12, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @XilaiZhang