Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment #50416
Conversation
…ers and configure a depth attachment
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Added a test that renders a scene using an embedder configured for Impeller/OpenGL with some workarounds for ANGLE. PTAL |
There was a problem hiding this comment.
LGTM (but not to CI)
Thanks for pulling on this string @jason-simmons
jason-simmons
added
the
autosubmit
…ssing shaders and configure a depth attachment (flutter/engine#50416)
…ssing shaders and configure a depth attachment (flutter/engine#50416)
…143393) flutter/engine@8742f1c...0091a49 2024-02-13 [email protected] [Impeller] remove denylist entry. (flutter/engine#50605) 2024-02-13 [email protected] [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604) 2024-02-13 [email protected] Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416) 2024-02-13 [email protected] Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603) 2024-02-13 [email protected] [Impeller] replaced playground macros with functions (flutter/engine#50602) 2024-02-13 [email protected] Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575) 2024-02-13 6844906[email protected] [Fuchsia] Run tests with test arguments (flutter/engine#50478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.