Allow deprecated members from the Dart SDK to roll in. #50575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 13, 2024
…143393) flutter/engine@8742f1c...0091a49 2024-02-13 [email protected] [Impeller] remove denylist entry. (flutter/engine#50605) 2024-02-13 [email protected] [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604) 2024-02-13 [email protected] Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416) 2024-02-13 [email protected] Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603) 2024-02-13 [email protected] [Impeller] replaced playground macros with functions (flutter/engine#50602) 2024-02-13 [email protected] Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575) 2024-02-13 6844906[email protected] [Fuchsia] Run tests with test arguments (flutter/engine#50478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
At some point, we inherited a change from the repo-level `analysis_options.yaml` that [allowed deprecated](#50575) members to be used. We rely on that analyzer error to prevent `solo: true` from being committed in our tests ([example](https://github.com/flutter/engine/blob/b7dddee939f2429e5fd3574a63f9dfac4f486a33/lib/web_ui/test/ui/line_metrics_test.dart#L179) of one that slipped recently). This PR overrides the `deprecated_member_use` error to enable it inside the web engine.
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
These are obsolete with #50575.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely, without breaking the tree. This is a deliberate policy decision change.
See flutter/flutter#143312.