Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for the surface if it is valid #55277

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Add a check for the surface if it is valid #55277

merged 6 commits into from
Sep 24, 2024

Conversation

mahmuttaskiran
Copy link
Contributor

Fixes an issue where the Surface is not valid and the draw method is crashing.

flutter/flutter#155018

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@mahmuttaskiran mahmuttaskiran force-pushed the fix_invalid_surface_crash branch 2 times, most recently from 45f5c19 to 982f51f Compare September 18, 2024 10:54
@mahmuttaskiran mahmuttaskiran force-pushed the fix_invalid_surface_crash branch from 982f51f to 3550482 Compare September 18, 2024 12:33
@matanlurey matanlurey requested review from jonahwilliams and removed request for johnmccutchan September 24, 2024 17:15
jonahwilliams
jonahwilliams approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

shell/platform/android/test/io/flutter/plugin/platform/PlatformViewWrapperTest.java Outdated Show resolved Hide resolved
shell/platform/android/test/io/flutter/plugin/platform/PlatformViewWrapperTest.java Outdated Show resolved Hide resolved
shell/platform/android/test/io/flutter/plugin/platform/PlatformViewWrapperTest.java Outdated Show resolved Hide resolved
shell/platform/android/test/io/flutter/plugin/platform/PlatformViewWrapperTest.java Outdated Show resolved Hide resolved
mahmuttaskiran and others added 4 commits September 24, 2024 21:39
@mahmuttaskiran @jonahwilliams
Update shell/platform/android/test/io/flutter/plugin/platform/Platfor…
575c8da 
…mViewWrapperTest.java


Delete comments

Co-authored-by: Jonah Williams <[email protected]>
@mahmuttaskiran @jonahwilliams
Delete comments
51438d7 
Co-authored-by: Jonah Williams <[email protected]>
@mahmuttaskiran @jonahwilliams
Update shell/platform/android/test/io/flutter/plugin/platform/Platfor…
2d26565 
…mViewWrapperTest.java

Co-authored-by: Jonah Williams <[email protected]>
@mahmuttaskiran @jonahwilliams
Update shell/platform/android/test/io/flutter/plugin/platform/Platfor…
af585cf 
…mViewWrapperTest.java

Co-authored-by: Jonah Williams <[email protected]>
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2024
@auto-submit auto-submit bot merged commit 57ae2d2 into flutter:main Sep 24, 2024
28 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 24, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2024
@engine-flutter-autoroll
57ae2d213 Add a check for the surface if it is valid (flutter/engine#…
8e6f1a1 
…55277)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 24, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (#…
2727377 
…155625)

flutter/engine@2a13c3a...7cd3d0b

2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397)
2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277)
2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270)
2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mahmuttaskiran mahmuttaskiran deleted the fix_invalid_surface_crash branch September 25, 2024 05:53
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (f…
de6df97 
…lutter#155625)

flutter/engine@2a13c3a...7cd3d0b

2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397)
2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277)
2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270)
2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (f…
5c95b28 
…lutter#155625)

flutter/engine@2a13c3a...7cd3d0b

2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397)
2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277)
2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270)
2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@yaakovschectman yaakovschectman mentioned this pull request Sep 26, 2024
Closed
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 27, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (f…
d905664 
…lutter#155625)

flutter/engine@2a13c3a...7cd3d0b

2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397)
2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277)
2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270)
2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 27, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Flutter Engine from 2a13c3a27e1f to 7cd3d0b1bb2e (4 revisions) (f…
fc95349 
…lutter#155625)

flutter/engine@2a13c3a...7cd3d0b

2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397)
2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277)
2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270)
2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@AlexV525 AlexV525 added the cp: stable cherry pick to the stable release candidate branch label Nov 1, 2024
flutteractionsbot pushed a commit to flutteractionsbot/engine that referenced this pull request Nov 1, 2024
@mahmuttaskiran
Add a check for the surface if it is valid (flutter#55277)
7686943 
Fixes an issue where the Surface is not valid and the `draw` method is crashing.

flutter/flutter#155018

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@pushpendraKh
Copy link

In which flutter version we can expect this fix?

@HongZhiQing
Copy link

In which flutter version we can expect this fix?

Same question.

@mahmuttaskiran
Copy link
Contributor Author

It was released in 3.24.5
https://github.com/flutter/flutter/blob/stable/CHANGELOG.md#3245

@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: stable cherry pick to the stable release candidate branch platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mahmuttaskiran @pushpendraKh @HongZhiQing @matanlurey @jonahwilliams @AlexV525