[Impeller] finish wiring up external textures for macOS embedder. #55347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
jonahwilliams
commented
Sep 24, 2024
| impeller::TextureDescriptor yDesc; | ||
| yDesc.storage_mode = impeller::StorageMode::kDevicePrivate; | ||
| yDesc.format = impeller::PixelFormat::kR8UNormInt; | ||
| yDesc.size = impeller::ISize(yTex.width, yTex.height); |
There was a problem hiding this comment.
Note that this code was hitting asserts running the AV video player example app because the sizes supplied didn't match the actual texture sizes. I changed the logic to read the texture descriptor size from the textures themselves so this can't get out of sync.
jonahwilliams
changed the title
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2024
…155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155625) flutter/engine@2a13c3a...7cd3d0b 2024-09-24 [email protected] Roll Dart SDK from 24ed9af6a961 to 7af8c4882e07 (1 revision) (flutter/engine#55397) 2024-09-24 [email protected] Add a check for the surface if it is valid (flutter/engine#55277) 2024-09-24 [email protected] [Flutter GPU] Add setStencilReference to RenderPass. (flutter/engine#55270) 2024-09-24 [email protected] [Impeller] finish wiring up external textures for macOS embedder. (flutter/engine#55347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#135898
Note that the macOS embedder is still using the apple texture cache object from the SkiaMetalContext. it can't initialize an equivalent ImpellerMetalContext without creating a second copy of the content context and all that jazz, so I'm leaving that as is for now.